sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shuaishuai Nie" <shuai...@microsoft.com>
Subject Re: Review Request: Review request for SQOOP-1035 "Add MS Sqoop Connecter tests to repo"
Date Wed, 12 Jun 2013 17:30:09 GMT


> On June 9, 2013, 4:23 p.m., Jarek Cecho wrote:
> > src/test/org/apache/sqoop/manager/MSSQLTestUtils.java, lines 46-63
> > <https://reviews.apache.org/r/10987/diff/5/?file=295735#file295735line46>
> >
> >     Is there a linux equivalent for these commands?

This is no longer necessary for the integration test, so removed from the code


> On June 9, 2013, 4:23 p.m., Jarek Cecho wrote:
> > conf/MSTest.properties, lines 1-5
> > <https://reviews.apache.org/r/10987/diff/5/?file=295730#file295730line1>
> >
> >     The top level conf/ directory should be used only for code that is mean to be
used for the actual product, not for the tests. Would it be feasible to move it somewhere
else? For example to testdata/ or src/test?
> >     
> >     Also this file is missing Apache License.

moved to SQOOP_HOME/testdata/


> On June 9, 2013, 4:23 p.m., Jarek Cecho wrote:
> > testdata/DatatypeTestData-export-lite.txt, line 1
> > <https://reviews.apache.org/r/10987/diff/5/?file=295749#file295749line1>
> >
> >     This file do not have a license. We need to either put a license here or configure
RAT to skip checking this file.

It seems the /testdata/ folder is excluded by rat in /src/scripts/rat-violation.sh already


> On June 9, 2013, 4:23 p.m., Jarek Cecho wrote:
> > testdata/DatatypeTestData-import-lite.txt, line 1
> > <https://reviews.apache.org/r/10987/diff/5/?file=295750#file295750line1>
> >
> >     This file do not have a license. We need to either put a license here or configure
RAT to skip checking this file.

It seems the /testdata/ folder is excluded by rat in /src/scripts/rat-violation.sh already


- Shuaishuai


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10987/#review21151
-----------------------------------------------------------


On May 23, 2013, 5:55 p.m., Shuaishuai Nie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10987/
> -----------------------------------------------------------
> 
> (Updated May 23, 2013, 5:55 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> Add the MS Sqoop connector tests that test integration scenarios with SQL Server to the
repo.
> 
> 
> This addresses bug SQOOP-1035.
>     https://issues.apache.org/jira/browse/SQOOP-1035
> 
> 
> Diffs
> -----
> 
>   conf/MSTest.properties PRE-CREATION 
>   src/test/com/cloudera/sqoop/hive/TestHiveImport.java 462ccf1 
>   src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java 27860c2 
>   src/test/org/apache/sqoop/manager/MSSQLTestData.java PRE-CREATION 
>   src/test/org/apache/sqoop/manager/MSSQLTestDataFileParser.java PRE-CREATION 
>   src/test/org/apache/sqoop/manager/MSSQLTestUtils.java PRE-CREATION 
>   src/test/org/apache/sqoop/manager/ManagerCompatExport.java PRE-CREATION 
>   src/test/org/apache/sqoop/manager/SQLServerDatatypeExportDelimitedFileManualTest.java
PRE-CREATION 
>   src/test/org/apache/sqoop/manager/SQLServerDatatypeExportSequenceFileManualTest.java
PRE-CREATION 
>   src/test/org/apache/sqoop/manager/SQLServerDatatypeImportDelimitedFileManualTest.java
PRE-CREATION 
>   src/test/org/apache/sqoop/manager/SQLServerDatatypeImportSequenceFileManualTest.java
PRE-CREATION 
>   src/test/org/apache/sqoop/manager/SQLServerHiveImportManualTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/manager/SQLServerManagerManualTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/manager/SQLServerMultiColsManualTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/manager/SQLServerMultiMapsManualTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/manager/SQLServerParseMethodsManualTest.java PRE-CREATION

>   src/test/org/apache/sqoop/manager/SQLServerQueryManualTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/manager/SQLServerSplitByManualTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/manager/SQLServerWhereManualTest.java PRE-CREATION 
>   testdata/DatatypeTestData-export-lite.txt PRE-CREATION 
>   testdata/DatatypeTestData-import-lite.txt PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/10987/diff/
> 
> 
> Testing
> -------
> 
> All tests passing after applying the patch
> 
> 
> Thanks,
> 
> Shuaishuai Nie
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message