sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kathleen Ting" <kathl...@apache.org>
Subject Re: Review Request: SQOOP-1067 Sqoop2: Tests should not use /tmp/ directory for storing data
Date Sat, 15 Jun 2013 19:27:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11614/#review21944
-----------------------------------------------------------

Ship it!


Ship It!

- Kathleen Ting


On June 4, 2013, 1:50 a.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11614/
> -----------------------------------------------------------
> 
> (Updated June 4, 2013, 1:50 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> I've propagated maven build directory into the tests and use that instead of hardcoded
/tmp/.
> 
> 
> This addresses bug SQOOP-1067.
>     https://issues.apache.org/jira/browse/SQOOP-1067
> 
> 
> Diffs
> -----
> 
>   execution/mapreduce/pom.xml a6299e1ae8b3f13a40d2be924b8bd35a4a0518a1 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestHdfsExtract.java b3e605096f762a6746a137f46c26ac8650a75989

>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestHdfsLoad.java 14591b4144c7c807f6cbb70e658b36781af9f4fb

> 
> Diff: https://reviews.apache.org/r/11614/diff/
> 
> 
> Testing
> -------
> 
> Integration and unit tests seems to be passing.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message