sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Venkat Ranganathan" <n....@live.com>
Subject Review Request: Fix SQOOP-1080
Date Sat, 15 Jun 2013 22:38:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11896/
-----------------------------------------------------------

Review request for Sqoop.


Description
-------

The reason we have this failure is because the hosts running the jenkins CI runs are all set
to Etc/UTC timezone which never has daylight saving time  (For example see https://builds.apache.org/computer/ubuntu6/systemInfo)
.   To fix this, I have denormalized  the time to UTC time from local time ( as the time we
read in is normalized) and print the time in UTC.   This will mean that we will have same
partitions irrespective of whether a timezone observes DST or not. 


Diffs
-----

  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartitioner.java
eef18f2 
  connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportPartitioner.java
522a515 

Diff: https://reviews.apache.org/r/11896/diff/


Testing
-------

Ran the complete tests with various timezones to check this


Thanks,

Venkat Ranganathan


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message