sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shruti Joshi" <shruti_jo...@persistent.co.in>
Subject Re: Review Request: Fix for SQOOP-107
Date Wed, 19 Jun 2013 10:12:24 GMT


> On June 8, 2013, 4:19 p.m., Jarek Cecho wrote:
> > Hi Shruti,
> > thank you very much for incorporating all my suggestions. I've dived into the patch
and I do have couple of notes.
> > 
> > Failing tests might have a lot of causes and it's hard to guess without entire log.
The HBase tests are particular hard to debug as they contain a lot of information and it's
sometimes hard to get oriented as the cause can be hidden somewhere in the middle of the log
and not necessary at the end. Some of known hiccups with HBase tests:
> > 
> > 1) If you are running on ubuntu, then it will by default have /etc/hosts file with
two entries - "127.0.0.1 localhost" and "127.0.1.1 $hostname". This won't work for HBase MiniCluster
as both localhost and machine hostname must point to the same IP.
> > 
> > 2) HBase team is not yet releasing artifacts compatible with Hadoop 2.0, so HBase
related tests are working only in profiles "20" and "100". Please note that default profile
is "23" (thus Hadoop 2) and therefore without specifying -Dhadoopversion=100, HBase tests
are expected to fail.

Hi Jarek,
Thanks a lot for your suggestions.
I tried to run HBase tests by specifying -Dhadoopversion=100 and also keeping the same IP
for localhost and machine hostname in /etc/hosts.
But still I am facing the same issues in my environment and hence can you please try to run
this test in your environment?
I am uploading the patch again with all the required changes and suggestions incorporated.

Shruti


> On June 8, 2013, 4:19 p.m., Jarek Cecho wrote:
> > src/java/org/apache/sqoop/hbase/ToStringPutTransformer.java, lines 180-182
> > <https://reviews.apache.org/r/11041/diff/4/?file=299930#file299930line180>
> >
> >     What about keeping the current behavior and allow user to decide whether to
include the columns used for row key in the data themselves?

I have modified code so as to keep the current behavior as it is Viz. including row key columns
in the data as per the user’s choice


> On June 8, 2013, 4:19 p.m., Jarek Cecho wrote:
> > src/test/com/cloudera/sqoop/hbase/HBaseImportTest.java, lines 158-159
> > <https://reviews.apache.org/r/11041/diff/4/?file=299931#file299931line158>
> >
> >     Please note that the Sqoop parameters must be appended to the end of the array
not to it's beginning.

Thanks for the suggestion.
I have followed the conventions used in the existing HBase tests while writing this test


- Shruti


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11041/#review21580
-----------------------------------------------------------


On June 3, 2013, 1:04 p.m., Shruti Joshi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11041/
> -----------------------------------------------------------
> 
> (Updated June 3, 2013, 1:04 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> Sqoop does not support importing data into hbase when table contains composite key.
> 
> 
> This addresses bug https://issues.cloudera.org/browse/SQOOP-107.
>     https://issues.apache.org/jira/browse/https://issues.cloudera.org/browse/SQOOP-107
> 
> 
> Diffs
> -----
> 
>   src/docs/man/hbase-args.txt 7164e93 
>   src/docs/user/hbase-args.txt 36b930b 
>   src/docs/user/hbase.txt 24c8df8 
>   src/java/org/apache/sqoop/hbase/HBasePutProcessor.java 6aca97f 
>   src/java/org/apache/sqoop/hbase/ToStringPutTransformer.java 13c765c 
>   src/test/com/cloudera/sqoop/hbase/HBaseImportTest.java d411f3d 
> 
> Diff: https://reviews.apache.org/r/11041/diff/
> 
> 
> Testing
> -------
> 
> ant test (default) was a success.
> 
> 
> Thanks,
> 
> Shruti Joshi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message