sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abraham Elmahrek" <...@cloudera.com>
Subject Re: Review Request: SQOOP-675 replace 'submission' cmd with 'start', 'stop' and 'status' cmds.
Date Thu, 20 Jun 2013 21:39:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11983/#review22190
-----------------------------------------------------------


I've only been able to briefly look at this review. So far so good. Please take into consideration
the comments below.


client/src/main/java/org/apache/sqoop/client/shell/SqoopFunction.java
<https://reviews.apache.org/r/11983/#comment45609>

    Nit: Put this in a utility class?



client/src/main/java/org/apache/sqoop/client/shell/SqoopFunction.java
<https://reviews.apache.org/r/11983/#comment45608>

    Nit: Put this in a utility class?


- Abraham Elmahrek


On June 20, 2013, 1:43 a.m., Mengwei Ding wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11983/
> -----------------------------------------------------------
> 
> (Updated June 20, 2013, 1:43 a.m.)
> 
> 
> Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek.
> 
> 
> Description
> -------
> 
> commit a8f82e64b4787ae48aa5b1b1beeb10214cc1e175
> Author: Mengwei Ding <mengwei.ding@cloudera.com>
> Date:   Wed Jun 19 17:56:57 2013 -0700
> 
>     SQOOP-675 replace 'submission' cmd with 'start', 'stop' and 'status' cmds.
> 
> :100644 100644 056fcc8... 1020209... M	client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 bf26761... 47a3bfa... M	client/src/main/java/org/apache/sqoop/client/shell/SqoopFunction.java
> :100644 100644 83f1c4f... aa87f20... M	client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java
> :000000 100644 0000000... ac7b2cf... A	client/src/main/java/org/apache/sqoop/client/shell/StartCommand.java
> :000000 100644 0000000... bd96454... A	client/src/main/java/org/apache/sqoop/client/shell/StatusCommand.java
> :000000 100644 0000000... 60d8378... A	client/src/main/java/org/apache/sqoop/client/shell/StopCommand.java
> :100644 000000 993bbde... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/SubmissionCommand.java
> :100644 000000 04bcf45... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java
> :100644 000000 1a6d896... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java
> :100644 000000 c407d01... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/SubmissionStopFunction.java
> :100644 100644 b159757... 2092a33... M	client/src/main/resources/client-resource.properties
> :100644 100644 073d547... a103277... M	docs/src/site/sphinx/CommandLineClient.rst
> 
> 
> This addresses bug SQOOP-675.
>     https://issues.apache.org/jira/browse/SQOOP-675
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/core/Constants.java 056fcc8 
>   client/src/main/java/org/apache/sqoop/client/shell/SqoopFunction.java bf26761 
>   client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java 83f1c4f 
>   client/src/main/java/org/apache/sqoop/client/shell/StartCommand.java PRE-CREATION 
>   client/src/main/java/org/apache/sqoop/client/shell/StatusCommand.java PRE-CREATION

>   client/src/main/java/org/apache/sqoop/client/shell/StopCommand.java PRE-CREATION 
>   client/src/main/java/org/apache/sqoop/client/shell/SubmissionCommand.java 993bbde 
>   client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java 04bcf45

>   client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java 1a6d896

>   client/src/main/java/org/apache/sqoop/client/shell/SubmissionStopFunction.java c407d01

>   client/src/main/resources/client-resource.properties b159757 
>   docs/src/site/sphinx/CommandLineClient.rst 073d547 
> 
> Diff: https://reviews.apache.org/r/11983/diff/
> 
> 
> Testing
> -------
> 
> Done several manual test for all these 3 commands and their options.
> 
> 
> Thanks,
> 
> Mengwei Ding
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message