sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shruti Joshi" <shruti_jo...@persistent.co.in>
Subject Re: Review Request: Fix for SQOOP-107
Date Fri, 21 Jun 2013 03:40:47 GMT


> On June 19, 2013, 8:50 p.m., Jarek Cecho wrote:
> > Hi Shruti,
> > the patch no longer applies on the HEAD of branch trunk. Would you mind rebasing
it? I think that the culprit here is SQOOP-1083, where we split the HBase tests into multiple
files, so the change should be rather straightforward.

I have rebased my code and added composite key test-case in src/test/com/cloudera/sqoop/hbase/HBaseImportAddRowKeyTest.java


> On June 19, 2013, 8:50 p.m., Jarek Cecho wrote:
> > src/java/org/apache/sqoop/hbase/ToStringPutTransformer.java, lines 96-97
> > <https://reviews.apache.org/r/11041/diff/5/?file=308349#file308349line96>
> >
> >     Nit: Assuming that we are only iterating over the generated array, is there
a reason why we need the compositeKeyAttributes defined as List? Shouldn't the array returned
by the split() method be sufficient? I'm not quite sure what is the gain here to transform
the Array into List.

The compositeKeyAttributes is required to be of type List, because in 'putRecordInHBase' method,
we have to check whether the column is a part of composite key or not using 'contains' method.
If it is of type Array, we need to iterate using 'for loop'.


- Shruti


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11041/#review22119
-----------------------------------------------------------


On June 20, 2013, 8:49 a.m., Shruti Joshi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11041/
> -----------------------------------------------------------
> 
> (Updated June 20, 2013, 8:49 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> Sqoop does not support importing data into hbase when table contains composite key.
> 
> 
> This addresses bug https://issues.cloudera.org/browse/SQOOP-107.
>     https://issues.apache.org/jira/browse/https://issues.cloudera.org/browse/SQOOP-107
> 
> 
> Diffs
> -----
> 
>   src/docs/man/hbase-args.txt 7164e93 
>   src/docs/user/hbase-args.txt 36b930b 
>   src/docs/user/hbase.txt 24c8df8 
>   src/java/org/apache/sqoop/hbase/HBasePutProcessor.java 6aca97f 
>   src/java/org/apache/sqoop/hbase/ToStringPutTransformer.java 13c765c 
>   src/test/com/cloudera/sqoop/hbase/HBaseImportAddRowKeyTest.java bd1cd2d 
> 
> Diff: https://reviews.apache.org/r/11041/diff/
> 
> 
> Testing
> -------
> 
> ant test (default) was a success.
> 
> 
> Thanks,
> 
> Shruti Joshi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message