sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mengwei Ding" <mengwei.d...@cloudera.com>
Subject Re: Review Request 11983: SQOOP-675 replace 'submission' cmd with 'start', 'stop' and 'status' cmds.
Date Mon, 01 Jul 2013 16:17:33 GMT


> On June 29, 2013, 9:43 p.m., Jarek Cecho wrote:
> > client/src/main/java/org/apache/sqoop/client/shell/StartJobFunction.java, lines
70-74
> > <https://reviews.apache.org/r/11983/diff/4/?file=312990#file312990line70>
> >
> >     I would suggest to not catch this exception and let it propagate to the shell
itself. We do have exception callbacks defined so the exception will be processed correctly.

Sorry, Jarcec. I am pretty sure that I changed the code here. It seems like I made a mistake
with the commit version when I update this code review. Now, fixed.


- Mengwei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11983/#review22541
-----------------------------------------------------------


On June 28, 2013, 5:12 p.m., Mengwei Ding wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11983/
> -----------------------------------------------------------
> 
> (Updated June 28, 2013, 5:12 p.m.)
> 
> 
> Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
> 
> 
> Bugs: SQOOP-675
>     https://issues.apache.org/jira/browse/SQOOP-675
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> commit 96d06c080a2b13e30c3a074770cbbaec9d9453d7
> Author: Mengwei Ding <mengwei.ding@cloudera.com>
> Date:   Wed Jun 19 17:56:57 2013 -0700
> 
>     SQOOP-675 replace 'submission' cmd with 'start', 'stop' and 'status' cmds.
> 
> :100644 100644 06f8162... 5c12316... M	client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 83f1c4f... aa87f20... M	client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java
> :000000 100644 0000000... 3d8889f... A	client/src/main/java/org/apache/sqoop/client/shell/StartCommand.java
> :000000 100644 0000000... 1ffda46... A	client/src/main/java/org/apache/sqoop/client/shell/StartJobFunction.java
> :000000 100644 0000000... 0be574e... A	client/src/main/java/org/apache/sqoop/client/shell/StatusCommand.java
> :000000 100644 0000000... b854a90... A	client/src/main/java/org/apache/sqoop/client/shell/StatusJobFunction.java
> :000000 100644 0000000... 2537438... A	client/src/main/java/org/apache/sqoop/client/shell/StopCommand.java
> :000000 100644 0000000... 49ab461... A	client/src/main/java/org/apache/sqoop/client/shell/StopJobFunction.java
> :100644 000000 993bbde... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/SubmissionCommand.java
> :100644 000000 04bcf45... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java
> :100644 000000 29144d1... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java
> :100644 000000 c407d01... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/SubmissionStopFunction.java
> :100644 100644 8a570a1... c7b2324... M	client/src/main/resources/client-resource.properties
> :100644 100644 a14898f... 22d6d47... M	docs/src/site/sphinx/CommandLineClient.rst
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/core/Constants.java 06f8162 
>   client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java 83f1c4f 
>   client/src/main/java/org/apache/sqoop/client/shell/StartCommand.java PRE-CREATION 
>   client/src/main/java/org/apache/sqoop/client/shell/StartJobFunction.java PRE-CREATION

>   client/src/main/java/org/apache/sqoop/client/shell/StatusCommand.java PRE-CREATION

>   client/src/main/java/org/apache/sqoop/client/shell/StatusJobFunction.java PRE-CREATION

>   client/src/main/java/org/apache/sqoop/client/shell/StopCommand.java PRE-CREATION 
>   client/src/main/java/org/apache/sqoop/client/shell/StopJobFunction.java PRE-CREATION

>   client/src/main/java/org/apache/sqoop/client/shell/SubmissionCommand.java 993bbde 
>   client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java 04bcf45

>   client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java 29144d1

>   client/src/main/java/org/apache/sqoop/client/shell/SubmissionStopFunction.java c407d01

>   client/src/main/resources/client-resource.properties 8a570a1 
>   docs/src/site/sphinx/CommandLineClient.rst a14898f 
> 
> Diff: https://reviews.apache.org/r/11983/diff/
> 
> 
> Testing
> -------
> 
> Done several manual test for all these 3 commands and their options.
> 
> 
> Thanks,
> 
> Mengwei Ding
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message