sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Raghav Gautam" <raghavgau...@gmail.com>
Subject Re: Review Request 12032: Incremental import using lastmodified mode always assumes column type to be timestamp, this patch fixes that
Date Mon, 01 Jul 2013 20:02:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12032/
-----------------------------------------------------------

(Updated July 1, 2013, 8:02 p.m.)


Review request for Sqoop.


Changes
-------

Hi Jarek,

I had introduced new method to retain old behavior for all connectors and overridden it in
OracleManager to make sure that the change happens only for Oracle. I have reimplemented the
method to use getColumnTypes method. Thanks for suggesting manager.getColumnTypes, I was able
to use it to greatly simplify the code changes. I have updated the patch.


Bugs: SQOOP-906
    https://issues.apache.org/jira/browse/SQOOP-906


Repository: sqoop-trunk


Description
-------

Incremental import using lastmodified mode always assumes column type to be TIMESTAMP which
is causing issues with Oracle Connector. This patch fixes that.


Diffs (updated)
-----

  src/java/org/apache/sqoop/manager/ConnManager.java c9e05da 
  src/java/org/apache/sqoop/manager/OracleManager.java edc888e 
  src/java/org/apache/sqoop/tool/ImportTool.java cb800b6 
  src/test/com/cloudera/sqoop/manager/OracleIncrementalImportTest.java PRE-CREATION 
  src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java 877d7f8 

Diff: https://reviews.apache.org/r/12032/diff/


Testing
-------

Unit tests & oracle third party tests are passing. Also tested manually.


Thanks,

Raghav Gautam


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message