sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Masatake Iwasaki" <iwasak...@oss.nttdata.co.jp>
Subject Review Request 12240: SQOOP-1118: Move PostgreSQL specific MR codes to org.apache.sqoop.mapreduce.posgresql
Date Wed, 03 Jul 2013 05:28:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12240/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-1118
    https://issues.apache.org/jira/browse/SQOOP-1118


Repository: sqoop-trunk


Description
-------

Attached patch includes following changes:
1. codes in org.apache.sqoop.mapreduce are moved to org.apache.sqoop.mapreduce.postgresql,
2. settings for PGBulkloadManagerManualTest such as database, and username ,tablespace and
path of pg_bulkload are made configurable via system property,
3. using not Configuration but JobConf in PGBulkloadManagerManualTest to follow changes in
DBConfiguration,
4. handling for the case JdbcUrl.getPort returns -1 is added to PGBulkloadExportMapper.


Diffs
-----

  src/java/org/apache/sqoop/manager/PGBulkloadManager.java 091fd15 
  src/java/org/apache/sqoop/mapreduce/PGBulkloadExportJob.java cc60233 
  src/java/org/apache/sqoop/mapreduce/PGBulkloadExportMapper.java 81b1333 
  src/java/org/apache/sqoop/mapreduce/PGBulkloadExportReducer.java 6f55861 
  src/java/org/apache/sqoop/mapreduce/postgresql/PGBulkloadExportJob.java PRE-CREATION 
  src/java/org/apache/sqoop/mapreduce/postgresql/PGBulkloadExportMapper.java PRE-CREATION

  src/java/org/apache/sqoop/mapreduce/postgresql/PGBulkloadExportReducer.java PRE-CREATION

  src/test/com/cloudera/sqoop/manager/PGBulkloadManagerManualTest.java 0403614 

Diff: https://reviews.apache.org/r/12240/diff/


Testing
-------

passed PGBulkloadManagerManualTest on PostgreSQL 9.2.4 and pg_bulkload 3.1.3.


Thanks,

Masatake Iwasaki


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message