sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request 12048: SQOOP-999: Support bulk load from HDFS to PostgreSQL using COPY ... FROM
Date Thu, 04 Jul 2013 00:20:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12048/#review22745
-----------------------------------------------------------

Ship it!


Looks good to me! Please upload the latest patch to the JIRA and I'll commit it.

- Jarek Cecho


On July 2, 2013, 9:28 p.m., Masatake Iwasaki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12048/
> -----------------------------------------------------------
> 
> (Updated July 2, 2013, 9:28 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-999
>     https://issues.apache.org/jira/browse/SQOOP-999
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Export with PostgreSQL Copy API can be realized in a straitforward way. Attached file
is not complete patch but sample implementation without tests and consideration for corner
cases.
> Though this code resolves dependency for PostgreSQL JDBC by ivy, is it acceptable for
the project?
> 
> 
> Diffs
> -----
> 
>   ivy.xml 750adfc 
>   ivy/libraries.properties 430d554 
>   src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java c085218 
>   src/java/org/apache/sqoop/mapreduce/postgresql/PostgreSQLCopyExportJob.java PRE-CREATION

>   src/java/org/apache/sqoop/mapreduce/postgresql/PostgreSQLCopyExportMapper.java PRE-CREATION

>   src/test/com/cloudera/sqoop/manager/DirectPostgreSQLExportManualTest.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/12048/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Masatake Iwasaki
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message