sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request 12240: SQOOP-1118: Move PostgreSQL specific MR codes to org.apache.sqoop.mapreduce.posgresql
Date Thu, 04 Jul 2013 00:29:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12240/#review22746
-----------------------------------------------------------


Hi Masatake,
thank you very much for your contribution! Would you mind splitting this patch into two different
JIRAs/commits? First that will only move the files around and second that will do all other
changes? I think that it will be much easier to follow the git history this way (for example
by doing git blame). I also do have couple of nits:


src/java/org/apache/sqoop/mapreduce/postgresql/PGBulkloadExportJob.java
<https://reviews.apache.org/r/12240/#comment46447>

    Nit: This variable seems to be unusued.



src/test/com/cloudera/sqoop/manager/PGBulkloadManagerManualTest.java
<https://reviews.apache.org/r/12240/#comment46446>

    Nit: This variable seems to be unused.


Jarcec

- Jarek Cecho


On July 3, 2013, 5:28 a.m., Masatake Iwasaki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12240/
> -----------------------------------------------------------
> 
> (Updated July 3, 2013, 5:28 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1118
>     https://issues.apache.org/jira/browse/SQOOP-1118
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Attached patch includes following changes:
> 1. codes in org.apache.sqoop.mapreduce are moved to org.apache.sqoop.mapreduce.postgresql,
> 2. settings for PGBulkloadManagerManualTest such as database, and username ,tablespace
and path of pg_bulkload are made configurable via system property,
> 3. using not Configuration but JobConf in PGBulkloadManagerManualTest to follow changes
in DBConfiguration,
> 4. handling for the case JdbcUrl.getPort returns -1 is added to PGBulkloadExportMapper.
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/manager/PGBulkloadManager.java 091fd15 
>   src/java/org/apache/sqoop/mapreduce/PGBulkloadExportJob.java cc60233 
>   src/java/org/apache/sqoop/mapreduce/PGBulkloadExportMapper.java 81b1333 
>   src/java/org/apache/sqoop/mapreduce/PGBulkloadExportReducer.java 6f55861 
>   src/java/org/apache/sqoop/mapreduce/postgresql/PGBulkloadExportJob.java PRE-CREATION

>   src/java/org/apache/sqoop/mapreduce/postgresql/PGBulkloadExportMapper.java PRE-CREATION

>   src/java/org/apache/sqoop/mapreduce/postgresql/PGBulkloadExportReducer.java PRE-CREATION

>   src/test/com/cloudera/sqoop/manager/PGBulkloadManagerManualTest.java 0403614 
> 
> Diff: https://reviews.apache.org/r/12240/diff/
> 
> 
> Testing
> -------
> 
> passed PGBulkloadManagerManualTest on PostgreSQL 9.2.4 and pg_bulkload 3.1.3.
> 
> 
> Thanks,
> 
> Masatake Iwasaki
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message