sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hari Shreedharan" <hshreedha...@cloudera.com>
Subject Re: Review Request 12196: SQOOP-1111 Sqoop2: Implement version detection and structure updates into Derby repository
Date Thu, 11 Jul 2013 21:58:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12196/#review23029
-----------------------------------------------------------

Ship it!


Looks good, couple of nits. can you fix and attach patch to jira?


core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java
<https://reviews.apache.org/r/12196/#comment46842>

    I will create a jira for this, but I think these methods should be renamed.



repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
<https://reviews.apache.org/r/12196/#comment46845>

    Log this instead of printing stack trace 



repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
<https://reviews.apache.org/r/12196/#comment46843>

    nit: We should call this QUERY_CREATE_TABLE_SYSTEM or all the others should be:
    
    (OP)_DELETE_SQ_SYSTEM for consistency.
    
    Similar for all other create queries


- Hari Shreedharan


On June 30, 2013, 2:07 a.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12196/
> -----------------------------------------------------------
> 
> (Updated June 30, 2013, 2:07 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1111
>     https://issues.apache.org/jira/browse/SQOOP-1111
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> I've implemented version detection, added new table for storing arbitrary key-value pairs
inside the repository (for repository purpose only) and propagated changes from SQOOP-943.
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java aa1aa8d3aee71de3ce337a1aa1fbbcc930a05429

>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 538def56fc10bee6dea0363fbef5e85dfdae621a

>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoConfigurationConstants.java
beb983c8cd2f67d849369113300ca095de6379a4 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java
4455f48946c3621f5fb326758a1121e9bd5b3cfd 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
0ec4da1c7fcea95d3988018329c781f09a1a8ad2 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
8cdbc63dd939b3ebe7b7784dd25523159651f237 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
7a9ce505dc95cfcaab8b9e05d1310659e40a1a64 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
5ace598e12fe8f4b493c072797791c7eb0eb1161 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInternals.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/12196/diff/
> 
> 
> Testing
> -------
> 
> Both unit and integration tests seems to be passing.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message