sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request 12032: Incremental import using lastmodified mode always assumes column type to be timestamp, this patch fixes that
Date Thu, 11 Jul 2013 22:24:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12032/#review23031
-----------------------------------------------------------


Hi Raghav, thank you very much for incorporating my suggestion, greatly appreciated! I think
that we can further simplify the change by the following:


src/java/org/apache/sqoop/tool/ImportTool.java
<https://reviews.apache.org/r/12032/#comment46846>

    This can be further simplified to manager.getColumnTypes(options.getTableName(), options.getSqlQuery()).get(options.getIncrementalTestColumn())
and we do not even need to touch the ConnManager, right?


Jarcec

- Jarek Cecho


On July 10, 2013, 6:33 p.m., Raghav Gautam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12032/
> -----------------------------------------------------------
> 
> (Updated July 10, 2013, 6:33 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-906
>     https://issues.apache.org/jira/browse/SQOOP-906
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Incremental import using lastmodified mode always assumes column type to be TIMESTAMP
which is causing issues with Oracle Connector. This patch fixes that.
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/manager/ConnManager.java c84c859 
>   src/java/org/apache/sqoop/manager/OracleManager.java 686bc19 
>   src/java/org/apache/sqoop/tool/ImportTool.java cb800b6 
>   src/test/com/cloudera/sqoop/TestIncrementalImport.java 02080df 
>   src/test/com/cloudera/sqoop/TestMerge.java 5010cf2 
>   src/test/com/cloudera/sqoop/ThirdPartyTests.java ada5c72 
>   src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java 877d7f8 
>   src/test/org/apache/sqoop/manager/oracle/OracleIncrementalImportTest.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/12032/diff/
> 
> 
> Testing
> -------
> 
> Unit tests & oracle third party tests are passing. Also tested manually.
> 
> 
> Thanks,
> 
> Raghav Gautam
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message