sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Raghav Gautam" <raghavgau...@gmail.com>
Subject Re: Review Request 12032: Incremental import using lastmodified mode always assumes column type to be timestamp, this patch fixes that
Date Fri, 12 Jul 2013 02:13:38 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated July 11, 2013, 7:13 p.m.)

Review request for Sqoop.


Removed manager.getLastModifiedCheckColumnType() as per review comment.

Bugs: SQOOP-906

Repository: sqoop-trunk


Incremental import using lastmodified mode always assumes column type to be TIMESTAMP which
is causing issues with Oracle Connector. This patch fixes that.

Diffs (updated)

  src/java/org/apache/sqoop/manager/ConnManager.java c84c859 
  src/java/org/apache/sqoop/manager/OracleManager.java 686bc19 
  src/java/org/apache/sqoop/tool/ImportTool.java cb800b6 
  src/test/com/cloudera/sqoop/TestIncrementalImport.java 02080df 
  src/test/com/cloudera/sqoop/TestMerge.java 5010cf2 
  src/test/com/cloudera/sqoop/ThirdPartyTests.java ada5c72 
  src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java 877d7f8 
  src/test/org/apache/sqoop/manager/oracle/OracleIncrementalImportTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/12032/diff/


Unit tests & oracle third party tests are passing. Also tested manually.


Raghav Gautam

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message