sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abraham Elmahrek" <...@cloudera.com>
Subject Re: Review Request 13051: SQOOP-1154 Sqoop2: Text partitioner might miss or include edge values
Date Wed, 31 Jul 2013 16:08:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13051/#review24353
-----------------------------------------------------------


Logical +1.

- Abraham Elmahrek


On July 30, 2013, 4:51 a.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13051/
> -----------------------------------------------------------
> 
> (Updated July 30, 2013, 4:51 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1154
>     https://issues.apache.org/jira/browse/SQOOP-1154
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> I've altered the methods to inject the lower bound into first partition and upper bound
to the last partition.
> 
> 
> Diffs
> -----
> 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartitioner.java
8d0c4ab017790985741c7effc6e1e58c54267a02 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportPartitioner.java
a33dd6cfe7b001f173e155b3fb694c5eb6e7368e 
> 
> Diff: https://reviews.apache.org/r/13051/diff/
> 
> 
> Testing
> -------
> 
> Altered one unit test and tested in the new integration test that is part of SQOOP-1114.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message