sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nick White" <nwh...@palantir.com>
Subject Re: Review Request 12949: SQOOP-1149: Support custom postgres types (e.g. inet for IP addresses) - which includes postgres enums.
Date Thu, 01 Aug 2013 15:43:04 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Aug. 1, 2013, 3:43 p.m.)

Review request for Sqoop.


I think I've come up with a nice way to abstract driver-specific Object types from the ClassWriter
- see the attached (backwards-compatible) patch.

Repository: sqoop-trunk


The patch adds a PostgresqlExportJob that replaces the OutputFormat (if needed) with a PostgresqlExportOutputFormat
that inserts casts into the generated SQL statement (e.g. insert into mytable values (?, ?::inet,
?)). The patch also consolidates the various functions on ConnManager that return SQL type
ints and type names into just one for each. This means the chunks of code in various parts
of the codebase that select which of the three (former) methods to call can be replaced with
a single call - and the call "routing" logic only appears in one place (ConnManager).

Diffs (updated)

  src/java/com/cloudera/sqoop/lib/JdbcWritableBridge.java 316547f 
  src/java/org/apache/sqoop/lib/JdbcWritableBridge.java afde585 
  src/java/org/apache/sqoop/manager/ConnManager.java f4b22f9 
  src/java/org/apache/sqoop/manager/PostgresqlManager.java bd882b9 
  src/java/org/apache/sqoop/orm/ClassWriter.java 1bd2a41 
  src/test/com/cloudera/sqoop/manager/PostgresqlExportTest.java 0ac4599 

Diff: https://reviews.apache.org/r/12949/diff/


I've added two cases to PostgresqlExportTest and tested them against a 9.3 database.


Nick White

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message