sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request 13273: SQOOP-1162: Sqoop2: 'show option' should have help entry showing that 'all' arg can be used
Date Wed, 14 Aug 2013 23:09:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13273/#review25191
-----------------------------------------------------------


Hi Mengwei,
thank you very much for working on this ticket! It seems to me that current changes won't
print anything if there aren't any arguments. I would suggest to add a check controlling that
either --all or --name are entered so that users are not confused. What do you think?

- Jarek Cecho


On Aug. 5, 2013, 6:10 p.m., Mengwei Ding wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13273/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2013, 6:10 p.m.)
> 
> 
> Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
> 
> 
> Bugs: SQOOP-1162
>     https://issues.apache.org/jira/browse/SQOOP-1162
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> commit 64ebb185e42578ec0138639780e4953e22d4cff9
> Author: Mengwei Ding <mengwei.ding@gmail.com>
> Date:   Mon Aug 5 10:47:29 2013 -0700
> 
>     SQOOP-1162: Sqoop2: 'show option' should have help entry showing that 'all' arg can
be used
> 
> :100644 100644 999790d... 7ebd4d3... M	client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 81c5612... 36b3ae8... M	client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java
> :100644 100644 1a8f963... 610b6b2... M	client/src/main/resources/client-resource.properties
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/core/Constants.java 999790d 
>   client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java 81c5612

>   client/src/main/resources/client-resource.properties 1a8f963 
> 
> Diff: https://reviews.apache.org/r/13273/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mengwei Ding
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message