sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request 13452: SQOOP-924 Sqoop2: Devguide: Describe wire protocol
Date Mon, 19 Aug 2013 15:44:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13452/#review25216
-----------------------------------------------------------


Hi Mengwei,
thank you for putting this Guide together, it's very helpful!


docs/src/site/sphinx/NetworkAPI.rst
<https://reviews.apache.org/r/13452/#comment49507>

    Do you think that we can rename the document to "Sqoop REST API Guide", so that the name
is more descriptive?



docs/src/site/sphinx/NetworkAPI.rst
<https://reviews.apache.org/r/13452/#comment49508>

    ... interacting with Sqoop server.



docs/src/site/sphinx/NetworkAPI.rst
<https://reviews.apache.org/r/13452/#comment49509>

    Please provide link from "client API" to the client API documentation.



docs/src/site/sphinx/NetworkAPI.rst
<https://reviews.apache.org/r/13452/#comment49511>

    Can we add here something like general introduction? I think that from the introduction
user should have an idea that the REST API is offered as an HTTP call and that data will be
encoded using json.



docs/src/site/sphinx/NetworkAPI.rst
<https://reviews.apache.org/r/13452/#comment49510>

    The host|port|webapp might be problematic when one will be running Sqoop on https. Let's
just describe that you need Sqoop server URL.



docs/src/site/sphinx/NetworkAPI.rst
<https://reviews.apache.org/r/13452/#comment49513>

    I don't think that Connection vs. Job is difference  belong here, as it's not specific
to web API. It should be described in more generic section.



docs/src/site/sphinx/NetworkAPI.rst
<https://reviews.apache.org/r/13452/#comment49512>

    Form is not a group of inputs, it's list of inputs (e.g. different data type).



docs/src/site/sphinx/NetworkAPI.rst
<https://reviews.apache.org/r/13452/#comment49514>

    I would suggest not to use word function here as HTTP do not have functions. Perhaps a
HTTP call or REST call?



docs/src/site/sphinx/NetworkAPI.rst
<https://reviews.apache.org/r/13452/#comment49515>

    The example seems to be unnecessary long, would you mind cutting it? 


- Jarek Cecho


On Aug. 9, 2013, 10:56 p.m., Mengwei Ding wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13452/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2013, 10:56 p.m.)
> 
> 
> Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
> 
> 
> Bugs: SQOOP-924
>     https://issues.apache.org/jira/browse/SQOOP-924
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> commit 1b533c60a4c4f0da12b9140fdb0838ba24c00045
> Author: Mengwei Ding <mengwei.ding@gmail.com>
> Date:   Tue Aug 6 14:34:40 2013 -0700
> 
>     SQOOP-924 Sqoop2: Devguide: Describe wire protocol
> 
> :000000 100644 0000000... 1022795... A	docs/src/site/sphinx/NetworkAPI.rst
> :100644 100644 15ddfbb... 1d83db5... M	docs/src/site/sphinx/index.rst
> 
> 
> Diffs
> -----
> 
>   docs/src/site/sphinx/NetworkAPI.rst PRE-CREATION 
>   docs/src/site/sphinx/index.rst 15ddfbb 
> 
> Diff: https://reviews.apache.org/r/13452/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mengwei Ding
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message