sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Review Request 13794: SQOOP-1183 Sqoop2: Add getConnector(String) to the client API
Date Sat, 24 Aug 2013 22:31:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13794/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-1183
    https://issues.apache.org/jira/browse/SQOOP-1183


Repository: sqoop-sqoop2


Description
-------

Added proposed methods getConnector(String) and newConnection(Strong).


Diffs
-----

  client/src/main/java/org/apache/sqoop/client/ClientError.java aafb5b0891df23726b14c730f570f745990cb8e7

  client/src/main/java/org/apache/sqoop/client/SqoopClient.java f9e7ddd32a841a0a79488b48e278ae4cee7897e5

  client/src/test/java/org/apache/sqoop/client/TestSqoopClient.java 3e0544a00b93bbf30bb723a2b070caa5256618a1

  test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableExportTest.java
ee8b97bd1f16b110432569b3ad9d5f353e58cddd 
  test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableImportTest.java
b500828de0ff206b36c4cbe370a5f1737e6e0a2c 
  test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/imports/PartitionerTest.java
50fce74dbf707581458f320b25eb9c991be43582 

Diff: https://reviews.apache.org/r/13794/diff/


Testing
-------

Added unit test to verify the caching logic for the new methods and altered integration tests
to use this new method.


Thanks,

Jarek Cecho


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message