sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Venkat Ranganathan" <n....@live.com>
Subject Re: Review Request 13635: SQOOP-1176: Added support for storing imported data as json.
Date Mon, 09 Sep 2013 05:01:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13635/#review25982
-----------------------------------------------------------


Thanks for working on this.   I have a small nit noted below.   Also, can you please add tests?

Thanks


src/java/org/apache/sqoop/SqoopOptions.java
<https://reviews.apache.org/r/13635/#comment50731>

    You may want to name the property to.json consistent with others


- Venkat Ranganathan


On Sept. 9, 2013, 1:01 a.m., Erik Selin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13635/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2013, 1:01 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/SQOOP-1176
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SQOOP-1176
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Adding support for storing imported data as JSON.
> 
> 
> Diffs
> -----
> 
>   ivy.xml d7486e0 
>   src/java/org/apache/sqoop/SqoopOptions.java 01805f9 
>   src/java/org/apache/sqoop/orm/ClassWriter.java 7fdf434 
>   src/java/org/apache/sqoop/tool/BaseSqoopTool.java e02a93b 
> 
> Diff: https://reviews.apache.org/r/13635/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Erik Selin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message