sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request 14022: SQOOP-974 Support for stage table
Date Tue, 10 Sep 2013 09:44:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14022/#review26015
-----------------------------------------------------------


Hi Raghav,
thank you very much for moving the functionality to the destroyer! I do have couple of questions,
mostly nits:


connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutor.java
<https://reviews.apache.org/r/14022/#comment50778>

    Nit: Wouldn't be simpler to call LOG.warn(message, exception) rather than building the
string manually?



connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportDestroyer.java
<https://reviews.apache.org/r/14022/#comment50782>

    Nit: Unused imports



connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportDestroyer.java
<https://reviews.apache.org/r/14022/#comment50783>

    Nit: Unused imports



connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutorTest.java
<https://reviews.apache.org/r/14022/#comment50779>

    Nit: Seems as not necessary any more.



connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExportInitializer.java
<https://reviews.apache.org/r/14022/#comment50780>

    Nit: This change do not seem to be necessary.



test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedExportTest.java
<https://reviews.apache.org/r/14022/#comment50781>

    Please move this file to "exports" sub module.


Jarcec

- Jarek Cecho


On Sept. 9, 2013, 9:41 p.m., Raghav Gautam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14022/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2013, 9:41 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: sqoop-974
>     https://issues.apache.org/jira/browse/sqoop-974
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> This patch adds support for stage table to Sqoop2.
> 
> 
> Diffs
> -----
> 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorError.java
671bb4a 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutor.java
75cf9d9 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportDestroyer.java
588e236 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportInitializer.java
7212843 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportDestroyer.java
2cf07fe 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java
4e24517 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ExportTableForm.java
a311c06 
>   connector/connector-generic-jdbc/src/main/resources/generic-jdbc-connector-resources.properties
0950e32 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutorTest.java
PRE-CREATION 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExportInitializer.java
f83aaa2 
>   test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedExportTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/14022/diff/
> 
> 
> Testing
> -------
> 
> Unit tests as well as integration tests have been added.
> All the tests pass.
> Feature was manually tested.
> 
> 
> Thanks,
> 
> Raghav Gautam
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message