sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request 14542: Review of SQOOP-1213
Date Tue, 08 Oct 2013 23:12:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14542/#review26800
-----------------------------------------------------------


Hi James,
thank you very much for working on this JIRA! I do have one small comment:


src/java/org/apache/sqoop/util/CredentialsUtil.java
<https://reviews.apache.org/r/14542/#comment52149>

    I've noticed that we are using rather Path.getFileSystem(Configuration) then the FileSystem.get()
API call in the rest of the Sqoop codebase. Do you think that we could change it to be consistent?


Jarcec

- Jarek Cecho


On Oct. 8, 2013, 8:46 p.m., James Anderson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14542/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2013, 8:46 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1213
>     https://issues.apache.org/jira/browse/SQOOP-1213
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> In order to support reading password files from Amazon S3, instantiate the FileSystem
object with the appropriate URI based on the provided path.
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/util/CredentialsUtil.java 2d88bd3 
> 
> Diff: https://reviews.apache.org/r/14542/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> James Anderson
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message