sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request 16020: Fix for SQOOP-1249
Date Wed, 04 Dec 2013 23:36:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16020/#review29774
-----------------------------------------------------------


Good catch Venkat! Couple of nits:


src/test/org/apache/sqoop/hcat/HCatalogImportTest.java
<https://reviews.apache.org/r/16020/#comment57255>

    Nit: The method do not seem to be used.



src/test/org/apache/sqoop/hcat/HCatalogImportTest.java
<https://reviews.apache.org/r/16020/#comment57256>

    Nit: The parameter isQuery do not seem to be used.


Jarcec

- Jarek Cecho


On Dec. 4, 2013, 10:54 p.m., Venkat Ranganathan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16020/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2013, 10:54 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1249
>     https://issues.apache.org/jira/browse/SQOOP-1249
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Fix for Sqoop-1249.   The validation has been fixed to allow one of target-dir or hcatalog|hbase|accumulo
table as the destination
> 
> Added one more test case for query imports into a hcatalog table
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/tool/ImportTool.java 50826e9 
>   src/test/org/apache/sqoop/hcat/HCatalogImportTest.java 13850fc 
> 
> Diff: https://reviews.apache.org/r/16020/diff/
> 
> 
> Testing
> -------
> 
> Ran all tests and checkstyle verification
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message