sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request 16252: Fix for SQOOP-1259: Sqoop on windows issues
Date Mon, 16 Dec 2013 11:18:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16252/#review30440
-----------------------------------------------------------

Ship it!


I'm not a windows user, so I can't really verify the patch nor test it. However the code changes
seems good and I trust Venkat's tests. Hence I'll commit it. Please do not hesitate and let
me know if there are any concerns.

- Jarek Cecho


On Dec. 13, 2013, 9:01 p.m., Venkat Ranganathan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16252/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2013, 9:01 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1259
>     https://issues.apache.org/jira/browse/SQOOP-1259
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Fixed Sqoop configure-sqoop.cmd script to properly handle HCATALOG configuration and
also add the right HBase and Zookeeper configuration files
> 
> Fixed SqoopHCatUtilities to properly invoke the hcat python script
> 
> 
> Diffs
> -----
> 
>   .gitattributes bd835f9 
>   bin/configure-sqoop.cmd 4598bc8 
>   src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java 09652df 
> 
> Diff: https://reviews.apache.org/r/16252/diff/
> 
> 
> Testing
> -------
> 
> Ran all unit tests, checked on Windows and no new checkstyle isues added
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message