sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request 15592: SQOOP-1226 --password-file option triggers FileSystemClosed exception at end of Oozie action
Date Thu, 16 Jan 2014 20:06:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15592/
-----------------------------------------------------------

(Updated Jan. 16, 2014, 8:06 p.m.)


Review request for Sqoop.


Changes
-------

Added comment to explain why the FileSystem is not closed.


Bugs: SQOOP-1226
    https://issues.apache.org/jira/browse/SQOOP-1226


Repository: sqoop-trunk


Description
-------

I've discussed the issue with HDFS Committer Colin and he recommended us to remove the FileSystem#close
call, so this patch is doing exactly this.


Diffs (updated)
-----

  src/java/org/apache/sqoop/util/password/FilePasswordLoader.java 86b71ec423b40eaa5b1aca30d00ba7ea1329728a


Diff: https://reviews.apache.org/r/15592/diff/


Testing
-------

All unit tests seems to be passing.


Thanks,

Jarek Cecho


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message