sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Jarcec Cecho (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-1268) Sqoop tarballs do not contain .gitignore and .gitattribute files
Date Wed, 22 Jan 2014 02:52:20 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13878182#comment-13878182
] 

Jarek Jarcec Cecho commented on SQOOP-1268:
-------------------------------------------

Thank you for taking a look into the patch [~venkatnrangan], appreciated!

bq. LGTM but do we need .gitignore and .gitattribute for binary packages also?

Excellent question. Currently the binary package is actually a super set of a source package,
e.g. entire source package is included in the binary package. It seemed natural to keep that
still valid by adding the files to the binary packages as well.

> Sqoop tarballs do not contain .gitignore and .gitattribute files
> ----------------------------------------------------------------
>
>                 Key: SQOOP-1268
>                 URL: https://issues.apache.org/jira/browse/SQOOP-1268
>             Project: Sqoop
>          Issue Type: Bug
>    Affects Versions: 1.4.4
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Jarek Jarcec Cecho
>            Priority: Trivial
>             Fix For: 1.4.5
>
>         Attachments: SQOOP-1268.patch
>
>
> It seems that both source and binary tarballs are missing {{.gitignore}} and {{.gitattributes}}
files. Even thought that we are not shipping the git repository itself the files are part
of our source code and thus I believe that we should ship them as well. Users might find them
handy.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message