sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request 17650: SQOOP-1278: Allow use of uncommitted isolation on databases that support is an import option
Date Tue, 04 Feb 2014 17:09:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17650/#review33603
-----------------------------------------------------------


Couple of nits:


src/docs/user/import.txt
<https://reviews.apache.org/r/17650/#comment63135>

    Can we further tweak this by also stating that not all connectors might following this
argument?



src/java/org/apache/sqoop/SqoopOptions.java
<https://reviews.apache.org/r/17650/#comment63137>

    I know that Java boolean will be false by default, but would you mind stating the default
value in initDefaults() method as well?



src/java/org/apache/sqoop/SqoopOptions.java
<https://reviews.apache.org/r/17650/#comment63136>

    Super nit: Unnecessary new line character.



src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java
<https://reviews.apache.org/r/17650/#comment63138>

    Nit: Seems as unnecessary import.



src/java/org/apache/sqoop/mapreduce/db/DBInputFormat.java
<https://reviews.apache.org/r/17650/#comment63139>

    Nit: Seems as unnecessary import.


Jarcec

- Jarek Cecho


On Feb. 3, 2014, 8:01 p.m., Venkat Ranganathan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17650/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2014, 8:01 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1278
>     https://issues.apache.org/jira/browse/SQOOP-1278
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Allow the use of read uncommitted isolation on all databases that support it.  Oracle
does not read uncommitted as a settable option in the JDBC drivers so it will behave as before
on Oracle.
> 
> 
> Diffs
> -----
> 
>   src/docs/user/common-args.txt 8a017f4 
>   src/docs/user/import.txt 0db6d97 
>   src/java/org/apache/sqoop/SqoopOptions.java 46e158c 
>   src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java b21560e 
>   src/java/org/apache/sqoop/mapreduce/db/DBConfiguration.java be942ce 
>   src/java/org/apache/sqoop/mapreduce/db/DBInputFormat.java 73ed94e 
>   src/java/org/apache/sqoop/tool/BaseSqoopTool.java 6d6f1ea 
>   src/test/com/cloudera/sqoop/TestSqoopOptions.java 686d398 
> 
> Diff: https://reviews.apache.org/r/17650/diff/
> 
> 
> Testing
> -------
> 
> One new test to test the option.  Explicitly tested with Oracle, DB2 and Postgresql.
  All unit tests passed
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message