sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request 18401: SQOOP-1290 Sqoop2: Kill Tomcat in case that Sqoop Server fails to load
Date Mon, 24 Feb 2014 16:09:17 GMT


> On Feb. 23, 2014, 9:57 p.m., Venkat Ranganathan wrote:
> > tools/src/main/java/org/apache/sqoop/tools/ToolRunner.java, line 71
> > <https://reviews.apache.org/r/18401/diff/1/?file=501005#file501005line71>
> >
> >     minor nit.  Do you think it makes sense to add a one line comment saying we
don't want to kill the Tomcat container in this case?

Yes that makes total sense, will update the patch in a minute.


- Jarek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18401/#review35248
-----------------------------------------------------------


On Feb. 22, 2014, 11:55 p.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18401/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2014, 11:55 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1290
>     https://issues.apache.org/jira/browse/SQOOP-1290
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> I've provided similar solution as has been applied to Oozie via OOZIE-786. On top of
that I've also added ability to disable this behavior in case that user will run Sqoop in
Tomcat that is also running other apps.
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/sqoop/core/ConfigurationConstants.java f225fcb 
>   server/src/main/java/org/apache/sqoop/server/ServerInitializer.java 44aea2e 
>   tools/src/main/java/org/apache/sqoop/tools/ToolRunner.java 73dc9c5 
> 
> Diff: https://reviews.apache.org/r/18401/diff/
> 
> 
> Testing
> -------
> 
> Verified the fix on a real cluster.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message