sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request 18401: SQOOP-1290 Sqoop2: Kill Tomcat in case that Sqoop Server fails to load
Date Mon, 24 Feb 2014 16:10:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18401/
-----------------------------------------------------------

(Updated Feb. 24, 2014, 4:10 p.m.)


Review request for Sqoop.


Changes
-------

Added helpful comment to the ToolRunner explaining the added line.


Bugs: SQOOP-1290
    https://issues.apache.org/jira/browse/SQOOP-1290


Repository: sqoop-sqoop2


Description
-------

I've provided similar solution as has been applied to Oozie via OOZIE-786. On top of that
I've also added ability to disable this behavior in case that user will run Sqoop in Tomcat
that is also running other apps.


Diffs (updated)
-----

  core/src/main/java/org/apache/sqoop/core/ConfigurationConstants.java f225fcb597fca7a80e52e71001bfea586de13a39

  server/src/main/java/org/apache/sqoop/server/ServerInitializer.java 44aea2eccd50d1b9fab17d894a0d927eaf89f712

  tools/src/main/java/org/apache/sqoop/tools/ToolRunner.java 73dc9c5ba6ea170bc20ccbfb501b13c8dada5c02


Diff: https://reviews.apache.org/r/18401/diff/


Testing
-------

Verified the fix on a real cluster.


Thanks,

Jarek Cecho


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message