sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hari Shreedharan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-1296) Sqoop2: Revert SQOOP-1233
Date Tue, 18 Mar 2014 21:04:44 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13939790#comment-13939790
] 

Hari Shreedharan commented on SQOOP-1296:
-----------------------------------------

+1. Please go ahead

> Sqoop2: Revert SQOOP-1233
> -------------------------
>
>                 Key: SQOOP-1296
>                 URL: https://issues.apache.org/jira/browse/SQOOP-1296
>             Project: Sqoop
>          Issue Type: Bug
>    Affects Versions: 1.99.3
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Jarek Jarcec Cecho
>            Priority: Minor
>             Fix For: 1.99.4
>
>
> I would like to propose reverting SQOOP-1233 (my own patch). In the JIRA I've removed
calls to {{MessageFormat}} and let the formatting propagate to {{IO}} object. However both
{{IO}} and {{MessageFormat}} are expecting different format of the formatting string resulting
in following ugliness:
> {code}
> sqoop:000> show version --all
> sqoop:000> help
> {0} version:
>   Sqoop {1} revision {2} 
>   Compiled by {3} on {4}{0} version:
>   Sqoop {1} revision {2} 
>   Compiled by {3} on {4}Protocol version:
>   {0}{0} version:
>   Sqoop {1} revision {2} 
>   Compiled by {3} on {4}{0} version:
>   Sqoop {1} revision {2} 
>   Compiled by {3} on {4}{0} version:
>   Sqoop {1} revision {2} 
>   Compiled by {3} on {4}Protocol version:
>   {0}For information about Sqoop, visit: http://sqoop.apache.org/
> Available commands:
>   {0} ({1}) {2}  {0} ({1}) {2}  {0} ({1}) {2}  {0} ({1}) {2}  {0} ({1}) {2}  {0} ({1})
{2}  {0} ({1}) {2}  {0} ({1}) {2}  {0} ({1}) {2}  {0} ({1}) {2}  {0} ({1}) {2}  {0} ({1})
{2}  {0} ({1}) {2}  {0} ({1}) {2}
> For help on a specific command type: help command
> sqoop:000>
> {code}
> My sincere apologies for not catching this during my testing. I'll go ahead and call
{{git revert}} if I'll get +1 from another committer.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message