From dev-return-10674-apmail-sqoop-dev-archive=sqoop.apache.org@sqoop.apache.org Tue Mar 18 21:04:57 2014 Return-Path: X-Original-To: apmail-sqoop-dev-archive@www.apache.org Delivered-To: apmail-sqoop-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EC05410327 for ; Tue, 18 Mar 2014 21:04:56 +0000 (UTC) Received: (qmail 77791 invoked by uid 500); 18 Mar 2014 21:04:52 -0000 Delivered-To: apmail-sqoop-dev-archive@sqoop.apache.org Received: (qmail 77345 invoked by uid 500); 18 Mar 2014 21:04:51 -0000 Mailing-List: contact dev-help@sqoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sqoop.apache.org Delivered-To: mailing list dev@sqoop.apache.org Received: (qmail 76210 invoked by uid 99); 18 Mar 2014 21:04:44 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Mar 2014 21:04:44 +0000 Date: Tue, 18 Mar 2014 21:04:44 +0000 (UTC) From: "Hari Shreedharan (JIRA)" To: dev@sqoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SQOOP-1296) Sqoop2: Revert SQOOP-1233 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SQOOP-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13939790#comment-13939790 ] Hari Shreedharan commented on SQOOP-1296: ----------------------------------------- +1. Please go ahead > Sqoop2: Revert SQOOP-1233 > ------------------------- > > Key: SQOOP-1296 > URL: https://issues.apache.org/jira/browse/SQOOP-1296 > Project: Sqoop > Issue Type: Bug > Affects Versions: 1.99.3 > Reporter: Jarek Jarcec Cecho > Assignee: Jarek Jarcec Cecho > Priority: Minor > Fix For: 1.99.4 > > > I would like to propose reverting SQOOP-1233 (my own patch). In the JIRA I've removed calls to {{MessageFormat}} and let the formatting propagate to {{IO}} object. However both {{IO}} and {{MessageFormat}} are expecting different format of the formatting string resulting in following ugliness: > {code} > sqoop:000> show version --all > sqoop:000> help > {0} version: > Sqoop {1} revision {2} > Compiled by {3} on {4}{0} version: > Sqoop {1} revision {2} > Compiled by {3} on {4}Protocol version: > {0}{0} version: > Sqoop {1} revision {2} > Compiled by {3} on {4}{0} version: > Sqoop {1} revision {2} > Compiled by {3} on {4}{0} version: > Sqoop {1} revision {2} > Compiled by {3} on {4}Protocol version: > {0}For information about Sqoop, visit: http://sqoop.apache.org/ > Available commands: > {0} ({1}) {2} {0} ({1}) {2} {0} ({1}) {2} {0} ({1}) {2} {0} ({1}) {2} {0} ({1}) {2} {0} ({1}) {2} {0} ({1}) {2} {0} ({1}) {2} {0} ({1}) {2} {0} ({1}) {2} {0} ({1}) {2} {0} ({1}) {2} {0} ({1}) {2} > For help on a specific command type: help command > sqoop:000> > {code} > My sincere apologies for not catching this during my testing. I'll go ahead and call {{git revert}} if I'll get +1 from another committer. -- This message was sent by Atlassian JIRA (v6.2#6252)