sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Venkat Ranganathan" <n....@live.com>
Subject Re: Review Request 21617: SQOOP-1321 Add ability to serialize SqoopOption into JobConf
Date Mon, 19 May 2014 17:14:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21617/#review43371
-----------------------------------------------------------

Ship it!


- Venkat Ranganathan


On May 19, 2014, 4:06 a.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21617/
> -----------------------------------------------------------
> 
> (Updated May 19, 2014, 4:06 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1321
>     https://issues.apache.org/jira/browse/SQOOP-1321
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> I've added code that is serializing the SqoopOptions into job.xml as suggested on the
JIRA.
> 
> Couple of observation:
> 
> * In my tests the job.xml has increased on average by 8% which seems acceptable
> * Password won't be serialized unless explicitly enabled via sqoop.metastore.client.record.password
(the property name is a bit misleading, but I would prefer not to change to keep backward
compatibility)
> 
> 
> Diffs
> -----
> 
>   conf/sqoop-site-template.xml eccd168 
>   src/java/org/apache/sqoop/mapreduce/ExportJobBase.java 53de9c9 
>   src/java/org/apache/sqoop/mapreduce/ImportJobBase.java 8b1493d 
>   src/java/org/apache/sqoop/mapreduce/JobBase.java ddef421 
>   src/java/org/apache/sqoop/mapreduce/MergeJob.java 5f32127 
> 
> Diff: https://reviews.apache.org/r/21617/diff/
> 
> 
> Testing
> -------
> 
> All tests are passing and I've also verified the functionality on real cluster.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message