sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Robson" <david.rob...@quest.com>
Subject Re: Review Request 18452: Add high performance Oracle connector into Sqoop
Date Tue, 17 Jun 2014 04:30:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18452/
-----------------------------------------------------------

(Updated June 17, 2014, 4:30 a.m.)


Review request for Sqoop.


Changes
-------

Update code to conform to checkstyle requirements.
There are 10 problems in checkstyle introduced by OraOop now (was over 5000) - I propose we
fix these 10 at a later date as they would involve larger code changes. This could be done
as part of the merge with default manager factory.


Bugs: SQOOP-1287
    https://issues.apache.org/jira/browse/SQOOP-1287


Repository: sqoop-trunk


Description
-------

Dell Software is contributing an Oracle connector for the Sqoop project.
This is an initial patch to get early feedback - it is not finished. At the moment it is just
the code itself - no tests or documentation.
There is still more work to do in the code - checkstyle and findbugs has not been resolved
as yet.


Diffs (updated)
-----

  COMPILING.txt ddbed30 
  build.xml 2dc99a8 
  conf/oraoop-site-template.xml PRE-CREATION 
  src/java/org/apache/sqoop/ConnFactory.java 61d3307 
  src/java/org/apache/sqoop/manager/oracle/OraOopConnManager.java PRE-CREATION 
  src/java/org/apache/sqoop/manager/oracle/OraOopConstants.java PRE-CREATION 
  src/java/org/apache/sqoop/manager/oracle/OraOopDBInputSplit.java PRE-CREATION 
  src/java/org/apache/sqoop/manager/oracle/OraOopDBRecordReader.java PRE-CREATION 
  src/java/org/apache/sqoop/manager/oracle/OraOopDataDrivenDBInputFormat.java PRE-CREATION

  src/java/org/apache/sqoop/manager/oracle/OraOopGenerics.java PRE-CREATION 
  src/java/org/apache/sqoop/manager/oracle/OraOopJdbcUrl.java PRE-CREATION 
  src/java/org/apache/sqoop/manager/oracle/OraOopLog.java PRE-CREATION 
  src/java/org/apache/sqoop/manager/oracle/OraOopLogFactory.java PRE-CREATION 
  src/java/org/apache/sqoop/manager/oracle/OraOopLogMessage.java PRE-CREATION 
  src/java/org/apache/sqoop/manager/oracle/OraOopManagerFactory.java PRE-CREATION 
  src/java/org/apache/sqoop/manager/oracle/OraOopOracleDataChunk.java PRE-CREATION 
  src/java/org/apache/sqoop/manager/oracle/OraOopOracleDataChunkExtent.java PRE-CREATION 
  src/java/org/apache/sqoop/manager/oracle/OraOopOracleDataChunkPartition.java PRE-CREATION

  src/java/org/apache/sqoop/manager/oracle/OraOopOracleQueries.java PRE-CREATION 
  src/java/org/apache/sqoop/manager/oracle/OraOopOutputFormatBase.java PRE-CREATION 
  src/java/org/apache/sqoop/manager/oracle/OraOopOutputFormatInsert.java PRE-CREATION 
  src/java/org/apache/sqoop/manager/oracle/OraOopOutputFormatUpdate.java PRE-CREATION 
  src/java/org/apache/sqoop/manager/oracle/OraOopUtilities.java PRE-CREATION 
  src/java/org/apache/sqoop/manager/oracle/OracleActiveInstance.java PRE-CREATION 
  src/java/org/apache/sqoop/manager/oracle/OracleConnectionFactory.java PRE-CREATION 
  src/java/org/apache/sqoop/manager/oracle/OracleTable.java PRE-CREATION 
  src/java/org/apache/sqoop/manager/oracle/OracleTableColumn.java PRE-CREATION 
  src/java/org/apache/sqoop/manager/oracle/OracleTableColumns.java PRE-CREATION 
  src/java/org/apache/sqoop/manager/oracle/OracleTablePartition.java PRE-CREATION 
  src/java/org/apache/sqoop/manager/oracle/OracleTablePartitions.java PRE-CREATION 
  src/java/org/apache/sqoop/manager/oracle/OracleVersion.java PRE-CREATION 
  src/test/com/cloudera/sqoop/manager/OracleUtils.java 70e2925 
  src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java 793c23e 
  src/test/com/cloudera/sqoop/testutil/ExportJobTestCase.java 4421f0c 
  src/test/com/cloudera/sqoop/testutil/ImportJobTestCase.java 9fc8eba 
  src/test/oraoop/create_users.sql PRE-CREATION 
  src/test/oraoop/pkg_tst_product_gen.pbk PRE-CREATION 
  src/test/oraoop/pkg_tst_product_gen.psk PRE-CREATION 
  src/test/oraoop/table_tst_product.xml PRE-CREATION 
  src/test/oraoop/table_tst_product_part.xml PRE-CREATION 
  src/test/oraoop/table_tst_product_special_chars.xml PRE-CREATION 
  src/test/oraoop/table_tst_product_subpart.xml PRE-CREATION 
  src/test/org/apache/sqoop/manager/oracle/ExportTest.java PRE-CREATION 
  src/test/org/apache/sqoop/manager/oracle/ImportTest.java PRE-CREATION 
  src/test/org/apache/sqoop/manager/oracle/OraOopOracleQueriesTest.java PRE-CREATION 
  src/test/org/apache/sqoop/manager/oracle/OraOopTestCase.java PRE-CREATION 
  src/test/org/apache/sqoop/manager/oracle/OraOopTestConstants.java PRE-CREATION 
  src/test/org/apache/sqoop/manager/oracle/OracleConnectionFactoryTest.java PRE-CREATION 
  src/test/org/apache/sqoop/manager/oracle/SystemImportTest.java PRE-CREATION 
  src/test/org/apache/sqoop/manager/oracle/TestOraOopDataDrivenDBInputFormat.java PRE-CREATION

  src/test/org/apache/sqoop/manager/oracle/TestOraOopJdbcUrl.java PRE-CREATION 
  src/test/org/apache/sqoop/manager/oracle/TestOraOopUtilities.java PRE-CREATION 
  src/test/org/apache/sqoop/manager/oracle/TestOracleTable.java PRE-CREATION 
  src/test/org/apache/sqoop/manager/oracle/TimestampDataTest.java PRE-CREATION 
  src/test/org/apache/sqoop/manager/oracle/util/BigDecimalGenerator.java PRE-CREATION 
  src/test/org/apache/sqoop/manager/oracle/util/BinaryDoubleGenerator.java PRE-CREATION 
  src/test/org/apache/sqoop/manager/oracle/util/BinaryFloatGenerator.java PRE-CREATION 
  src/test/org/apache/sqoop/manager/oracle/util/BlobGenerator.java PRE-CREATION 
  src/test/org/apache/sqoop/manager/oracle/util/BytesGenerator.java PRE-CREATION 
  src/test/org/apache/sqoop/manager/oracle/util/CharGenerator.java PRE-CREATION 
  src/test/org/apache/sqoop/manager/oracle/util/FloatGenerator.java PRE-CREATION 
  src/test/org/apache/sqoop/manager/oracle/util/HadoopFiles.java PRE-CREATION 
  src/test/org/apache/sqoop/manager/oracle/util/IntervalDaySecondGenerator.java PRE-CREATION

  src/test/org/apache/sqoop/manager/oracle/util/IntervalYearMonthGenerator.java PRE-CREATION

  src/test/org/apache/sqoop/manager/oracle/util/NCharGenerator.java PRE-CREATION 
  src/test/org/apache/sqoop/manager/oracle/util/OraOopTestDataGenerator.java PRE-CREATION

  src/test/org/apache/sqoop/manager/oracle/util/OraOopTestUtils.java PRE-CREATION 
  src/test/org/apache/sqoop/manager/oracle/util/OracleData.java PRE-CREATION 
  src/test/org/apache/sqoop/manager/oracle/util/OracleDataDefinition.java PRE-CREATION 
  src/test/org/apache/sqoop/manager/oracle/util/OracleTableDefinition.java PRE-CREATION 
  src/test/org/apache/sqoop/manager/oracle/util/RowIdGenerator.java PRE-CREATION 
  src/test/org/apache/sqoop/manager/oracle/util/TimestampGenerator.java PRE-CREATION 
  src/test/org/apache/sqoop/manager/oracle/util/URIGenerator.java PRE-CREATION 

Diff: https://reviews.apache.org/r/18452/diff/


Testing
-------


Thanks,

David Robson


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message