sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abraham Elmahrek" <...@cloudera.com>
Subject Re: Review Request 23047: SQOOP-1138 incremental lastmodified should re-use output directory
Date Fri, 27 Jun 2014 17:11:02 GMT


> On June 26, 2014, 11:44 p.m., Kathleen Ting wrote:
> > Thanks Abe for picking this up. I suspect the incremental lastmodified mode has
never lived up to the expected behavior of first merging old and new data together into the
final output and then preserving only the last updated value for each row. There seems to
be an expectation that SQOOP-1138 will do so but I’m not sure the current fix meets that.
Thoughts?

Good point Kate, new review coming up.


- Abraham


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23047/#review46813
-----------------------------------------------------------


On June 26, 2014, 6:23 p.m., Abraham Elmahrek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23047/
> -----------------------------------------------------------
> 
> (Updated June 26, 2014, 6:23 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1138
>     https://issues.apache.org/jira/browse/SQOOP-1138
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> commit f141c60558f5d2519fb3bba53ca25d43cc4a35c9
> Author: Abraham Elmahrek <abraham@elmahrek.com>
> Date:   Thu Jun 26 10:24:10 2014 -0700
> 
>     SQOOP-1138 incremental lastmodified should re-use output directory
>     
>     Added "append mode" to lastmodified incremental options.
> 
> :100644 100644 6cbb873... e4b64f0... M  src/java/org/apache/sqoop/tool/ImportTool.java
> :100644 100644 8eadcdd... 14719a8... M  src/test/com/cloudera/sqoop/TestIncrementalImport.java
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/tool/ImportTool.java 6cbb873 
>   src/test/com/cloudera/sqoop/TestIncrementalImport.java 8eadcdd 
> 
> Diff: https://reviews.apache.org/r/23047/diff/
> 
> 
> Testing
> -------
> 
> ran ant tests with new test.
> 
> 
> Thanks,
> 
> Abraham Elmahrek
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message