sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abraham Elmahrek" <...@cloudera.com>
Subject Re: Review Request 23201: Sqoop import code too large error
Date Wed, 09 Jul 2014 00:20:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23201/
-----------------------------------------------------------

(Updated July 9, 2014, 12:20 a.m.)


Review request for Sqoop, Gwen Shapira and Jarek Cecho.


Changes
-------

Forgot the test case!


Bugs: SQOOP-1239
    https://issues.apache.org/jira/browse/SQOOP-1239


Repository: sqoop-trunk


Description
-------

commit 4cb6a0406b33272b97265a29d56fdb4f2194bcbe
Author: Abraham Elmahrek <abraham@elmahrek.com>
Date:   Mon Jun 30 19:24:47 2014 -0700

    SQOOP-1239 Sqoop import code too large error
    
    Too many columns baloon the size of the method.
    Splitting methods up will enable these use cases.
    Here are a few limitations that someone could run into:
    - Max # of methods: 65535.
    - Max # of fields: 65535.

:100644 100644 df1ab72... a56e167... M  src/java/org/apache/sqoop/orm/ClassWriter.java


Diffs (updated)
-----

  src/java/org/apache/sqoop/orm/ClassWriter.java df1ab72 
  src/test/com/cloudera/sqoop/mapreduce/TestImportJob.java 9504974 

Diff: https://reviews.apache.org/r/23201/diff/


Testing
-------

+ Tested manually by importing a 2000 column table from MySQL MyISAM.
+ Ran tests.


Thanks,

Abraham Elmahrek


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message