sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abraham Elmahrek" <...@cloudera.com>
Subject Re: Review Request 23468: Sqoop2: From/To: Disable tests
Date Wed, 16 Jul 2014 21:32:59 GMT


> On July 16, 2014, 4:14 a.m., Jarek Cecho wrote:
> > I would never imagine that I'll +1 JIRA saying "disable tests", but yeah, let's
do it :)

You guys rock :).


- Abraham


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23468/#review47857
-----------------------------------------------------------


On July 15, 2014, 8:10 p.m., Abraham Elmahrek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23468/
> -----------------------------------------------------------
> 
> (Updated July 15, 2014, 8:10 p.m.)
> 
> 
> Review request for Sqoop, Gwen Shapira, Hari Shreedharan, and Jarek Cecho.
> 
> 
> Bugs: SQOOP-1379
>     https://issues.apache.org/jira/browse/SQOOP-1379
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> commit 6a52a7252037445b5d789539ab20a1d7c0f8d4a9
> Author: Abraham Elmahrek <abraham@elmahrek.com>
> Date:   Mon Jul 14 15:48:38 2014 -0700
> 
>     Sqoop2: From/To: Disable tests
>     
>     Comment the tests out so that there will not be any compilation errors.
>     Skip tests at maven level so that test failures are not obvious.
> 
> :100644 100644 eeffbb7... b5e7e61... M  client/src/test/java/org/apache/sqoop/client/TestSqoopClient.java
> :100644 100644 f4718c0... 4c229ae... M  common/src/test/java/org/apache/sqoop/common/TestMapContext.java
> :100644 100644 f556c1c... d8aa1d5... M  common/src/test/java/org/apache/sqoop/common/TestSqoopResponseCode.java
> :100644 100644 27d78f4... f853af0... M  common/src/test/java/org/apache/sqoop/common/TestVersionInfo.java
> :100644 100644 19f81a8... 205694a... M  common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java
> :100644 100644 e078474... 58ea308... M  common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java
> :100644 100644 5cc110a... e667755... M  common/src/test/java/org/apache/sqoop/json/TestFrameworkBean.java
> :100644 100644 e42b7df... 8638408... M  common/src/test/java/org/apache/sqoop/json/TestJobBean.java
> :100644 100644 7f98e5b... ce107a8... M  common/src/test/java/org/apache/sqoop/json/TestSchemaBean.java
> :100644 100644 0cf0651... 2c98d4f... M  common/src/test/java/org/apache/sqoop/json/TestThrowableBean.java
> :100644 100644 69dcb66... d3e118b... M  common/src/test/java/org/apache/sqoop/json/TestUtil.java
> :100644 100644 95ea6e1... 704d55b... M  common/src/test/java/org/apache/sqoop/json/TestValidationBean.java
> :100644 100644 c4223ec... 9cd7305... M  common/src/test/java/org/apache/sqoop/json/util/TestFormSerialization.java
> :100644 100644 ab5bbd4... e36308d... M  common/src/test/java/org/apache/sqoop/json/util/TestSchemaSerialization.java
> :100644 100644 08dfa7b... 6c76347... M  common/src/test/java/org/apache/sqoop/model/TestFormUtils.java
> :100644 100644 f3d4166... 942a056... M  common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java
> :100644 100644 cf9cf24... b955aa4... M  common/src/test/java/org/apache/sqoop/model/TestMBooleanInput.java
> :100644 100644 27959fb... aa58f05... M  common/src/test/java/org/apache/sqoop/model/TestMConnection.java
> :100644 100644 e2d2717... 0899dc3... M  common/src/test/java/org/apache/sqoop/model/TestMConnectionForms.java
> :100644 100644 f3ca317... b94c7de... M  common/src/test/java/org/apache/sqoop/model/TestMConnector.java
> :100644 100644 a25016a... 97baa32... M  common/src/test/java/org/apache/sqoop/model/TestMEnumInput.java
> :100644 100644 0bd55d9... 109f1f5... M  common/src/test/java/org/apache/sqoop/model/TestMForm.java
> :100644 100644 bd21fcb... 4894d2e... M  common/src/test/java/org/apache/sqoop/model/TestMFormList.java
> :100644 100644 15d9676... d0720f0... M  common/src/test/java/org/apache/sqoop/model/TestMFramework.java
> :100644 100644 1f38e6d... 14bca67... M  common/src/test/java/org/apache/sqoop/model/TestMIntegerInput.java
> :100644 100644 8b6f5dc... 355cdb9... M  common/src/test/java/org/apache/sqoop/model/TestMJob.java
> :100644 100644 b2bb0a5... 5c44c0a... M  common/src/test/java/org/apache/sqoop/model/TestMJobForms.java
> :100644 100644 120fb07... 99d147c... M  common/src/test/java/org/apache/sqoop/model/TestMMapInput.java
> :100644 100644 f336bab... 4fcb212... M  common/src/test/java/org/apache/sqoop/model/TestMNamedElement.java
> :100644 100644 000c6be... d68f06c... M  common/src/test/java/org/apache/sqoop/model/TestMPersistableEntity.java
> :100644 100644 2fe0335... b0223a7... M  common/src/test/java/org/apache/sqoop/model/TestMStringInput.java
> :100644 100644 3fd5a95... 7c9a3d9... M  common/src/test/java/org/apache/sqoop/model/TestMValidatedElement.java
> :100644 100644 99f4767... 5d6692d... M  common/src/test/java/org/apache/sqoop/submission/TestSubmissionStatus.java
> :100644 100644 0cf5d2b... 962a535... M  common/src/test/java/org/apache/sqoop/submission/counter/TestCounter.java
> :100644 100644 985009a... aac80d4... M  common/src/test/java/org/apache/sqoop/submission/counter/TestCounterGroup.java
> :100644 100644 8f8d617... 22839c9... M  common/src/test/java/org/apache/sqoop/submission/counter/TestCounters.java
> :100644 100644 a5c4e69... aad5eff... M  common/src/test/java/org/apache/sqoop/utils/TestClassUtils.java
> :100644 100644 1edc404... 88fe058... M  common/src/test/java/org/apache/sqoop/utils/TestMapResourceBundle.java
> :100644 100644 5b17a4e... 654a024... M  common/src/test/java/org/apache/sqoop/validation/TestStatus.java
> :100644 100644 bf0ade5... be6ee84... M  common/src/test/java/org/apache/sqoop/validation/TestValidation.java
> :100644 100644 e10a5b4... 26ceccd... M  connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutorTest.java
> :100644 100644 d55b0f1... 3c5ca39... M  connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExportInitializer.java
> :100644 100644 d4c4565... 70d9d55... M  connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExportLoader.java
> :100644 100644 a7ed6ba... af2681d... M  connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportExtractor.java
> :100644 100644 a33fa36... 40c70f1... M  connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportInitializer.java
> :100644 100644 679accf... 5b574c8... M  connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportPartitioner.java
> :100644 100644 cc0d984... e0c4561... M  core/src/test/java/org/apache/sqoop/framework/TestFrameworkMetadataUpgrader.java
> :100644 100644 7e25d34... f875ceb... M  core/src/test/java/org/apache/sqoop/framework/TestFrameworkValidator.java
> :100644 100644 d557b87... 31df04c... M  core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java
> :100644 100644 39d1b53... f4572b1... M  execution/mapreduce/src/test/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngineTest.java
> :100644 100644 b7079dd... 3c870be... M  execution/mapreduce/src/test/java/org/apache/sqoop/job/TestHdfsExtract.java
> :100644 100644 f849aae... 8b76cc9... M  execution/mapreduce/src/test/java/org/apache/sqoop/job/TestHdfsLoad.java
> :100644 100644 7b264c6... 424ed9b... M  execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java
> :100644 100644 91df426... 48fb61f... M  execution/mapreduce/src/test/java/org/apache/sqoop/job/io/TestData.java
> :100644 100644 0ded500... 7e434b7... M  execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java
> :100644 100644 bee8ab7... 2035e19... M  execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor.java
> :100644 100644 1e2f005... 41a92b5... M  pom.xml
> :100644 100644 20b87a1... f603cc1... M  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
> :100644 100644 f9e9217... bdd3c05... M  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectionHandling.java
> :100644 100644 745e128... 54ae726... M  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java
> :100644 100644 50d1235... 8b3326d... M  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestFrameworkHandling.java
> :100644 100644 15f9539... 5d3807d... M  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java
> :100644 100644 25e6196... 0d93348... M  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInternals.java
> :100644 100644 4325c5c... 2260a45... M  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java
> :100644 100644 8fce0dd... 8cfe076... M  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java
> :100644 100644 436fdfb... 39b48d8... M  test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableExportTest.java
> :100644 100644 465a16d... 9e6f991... M  test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableImportTest.java
> :100644 100644 e36437b... cb028bb... M  test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/exports/TableStagedExportTest.java
> :100644 100644 3642833... 1bc3b93... M  test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/imports/PartitionerTest.java
> :100644 100644 84d1a26... 126ca32... M  test/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.java
> :100644 100644 cea24b9... 5ebe95f... M  test/src/test/java/org/apache/sqoop/integration/server/VersionTest.java
> 
> 
> Diffs
> -----
> 
>   client/src/test/java/org/apache/sqoop/client/TestSqoopClient.java eeffbb7 
>   common/src/test/java/org/apache/sqoop/common/TestMapContext.java f4718c0 
>   common/src/test/java/org/apache/sqoop/common/TestSqoopResponseCode.java f556c1c 
>   common/src/test/java/org/apache/sqoop/common/TestVersionInfo.java 27d78f4 
>   common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java 19f81a8 
>   common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java e078474 
>   common/src/test/java/org/apache/sqoop/json/TestFrameworkBean.java 5cc110a 
>   common/src/test/java/org/apache/sqoop/json/TestJobBean.java e42b7df 
>   common/src/test/java/org/apache/sqoop/json/TestSchemaBean.java 7f98e5b 
>   common/src/test/java/org/apache/sqoop/json/TestThrowableBean.java 0cf0651 
>   common/src/test/java/org/apache/sqoop/json/TestUtil.java 69dcb66 
>   common/src/test/java/org/apache/sqoop/json/TestValidationBean.java 95ea6e1 
>   common/src/test/java/org/apache/sqoop/json/util/TestFormSerialization.java c4223ec

>   common/src/test/java/org/apache/sqoop/json/util/TestSchemaSerialization.java ab5bbd4

>   common/src/test/java/org/apache/sqoop/model/TestFormUtils.java 08dfa7b 
>   common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java f3d4166 
>   common/src/test/java/org/apache/sqoop/model/TestMBooleanInput.java cf9cf24 
>   common/src/test/java/org/apache/sqoop/model/TestMConnection.java 27959fb 
>   common/src/test/java/org/apache/sqoop/model/TestMConnectionForms.java e2d2717 
>   common/src/test/java/org/apache/sqoop/model/TestMConnector.java f3ca317 
>   common/src/test/java/org/apache/sqoop/model/TestMEnumInput.java a25016a 
>   common/src/test/java/org/apache/sqoop/model/TestMForm.java 0bd55d9 
>   common/src/test/java/org/apache/sqoop/model/TestMFormList.java bd21fcb 
>   common/src/test/java/org/apache/sqoop/model/TestMFramework.java 15d9676 
>   common/src/test/java/org/apache/sqoop/model/TestMIntegerInput.java 1f38e6d 
>   common/src/test/java/org/apache/sqoop/model/TestMJob.java 8b6f5dc 
>   common/src/test/java/org/apache/sqoop/model/TestMJobForms.java b2bb0a5 
>   common/src/test/java/org/apache/sqoop/model/TestMMapInput.java 120fb07 
>   common/src/test/java/org/apache/sqoop/model/TestMNamedElement.java f336bab 
>   common/src/test/java/org/apache/sqoop/model/TestMPersistableEntity.java 000c6be 
>   common/src/test/java/org/apache/sqoop/model/TestMStringInput.java 2fe0335 
>   common/src/test/java/org/apache/sqoop/model/TestMValidatedElement.java 3fd5a95 
>   common/src/test/java/org/apache/sqoop/submission/TestSubmissionStatus.java 99f4767

>   common/src/test/java/org/apache/sqoop/submission/counter/TestCounter.java 0cf5d2b 
>   common/src/test/java/org/apache/sqoop/submission/counter/TestCounterGroup.java 985009a

>   common/src/test/java/org/apache/sqoop/submission/counter/TestCounters.java 8f8d617

>   common/src/test/java/org/apache/sqoop/utils/TestClassUtils.java a5c4e69 
>   common/src/test/java/org/apache/sqoop/utils/TestMapResourceBundle.java 1edc404 
>   common/src/test/java/org/apache/sqoop/validation/TestStatus.java 5b17a4e 
>   common/src/test/java/org/apache/sqoop/validation/TestValidation.java bf0ade5 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutorTest.java
e10a5b4 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExportInitializer.java
d55b0f1 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExportLoader.java
d4c4565 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportExtractor.java
a7ed6ba 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportInitializer.java
a33fa36 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportPartitioner.java
679accf 
>   core/src/test/java/org/apache/sqoop/framework/TestFrameworkMetadataUpgrader.java cc0d984

>   core/src/test/java/org/apache/sqoop/framework/TestFrameworkValidator.java 7e25d34 
>   core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java d557b87 
>   execution/mapreduce/src/test/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngineTest.java
39d1b53 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestHdfsExtract.java b7079dd

>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestHdfsLoad.java f849aae 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java 7b264c6 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/io/TestData.java 91df426 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java
0ded500 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor.java
bee8ab7 
>   pom.xml 1e2f005 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
20b87a1 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectionHandling.java
f9e9217 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java
745e128 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestFrameworkHandling.java
50d1235 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java
15f9539 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInternals.java
25e6196 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java
4325c5c 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java
8fce0dd 
>   test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableExportTest.java
436fdfb 
>   test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableImportTest.java
465a16d 
>   test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/exports/TableStagedExportTest.java
e36437b 
>   test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/imports/PartitionerTest.java
3642833 
>   test/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.java
84d1a26 
>   test/src/test/java/org/apache/sqoop/integration/server/VersionTest.java cea24b9 
> 
> Diff: https://reviews.apache.org/r/23468/diff/
> 
> 
> Testing
> -------
> 
> ran mvn test.
> 
> 
> Thanks,
> 
> Abraham Elmahrek
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message