sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abraham Elmahrek" <...@cloudera.com>
Subject Re: Review Request 21898: Patch for SQOOP-1255 - https://issues.apache.org/jira/browse/SQOOP-1255
Date Fri, 18 Jul 2014 19:50:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21898/#review48144
-----------------------------------------------------------


Good stuff! A couple of thoughts:
- Are connections or jobs ever overwritten? I think that connections and jobs with the same
name should be overwritten.
- An ID map is sensible, but could we also use "name" to uniquely identify connections.


tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java
<https://reviews.apache.org/r/21898/#comment84442>

    NIT: Does this need a value?



tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java
<https://reviews.apache.org/r/21898/#comment84441>

    Many of these strings seem frequently used. Why not pull them out into constants? Though,
this might not matter with String interning.


- Abraham Elmahrek


On July 18, 2014, 4:11 p.m., Gwen Shapira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21898/
> -----------------------------------------------------------
> 
> (Updated July 18, 2014, 4:11 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Added tool for dumping user-generated data - connections, jobs and submissions. There's
an option to dump sensitive data (i.e. passwords) as well. 
> 
> 
> Diffs
> -----
> 
>   docs/src/site/sphinx/Tools.rst ad72cd1 
>   pom.xml 1e2f005 
>   tools/pom.xml 31eda1c 
>   tools/src/main/java/org/apache/sqoop/tools/tool/BuiltinTools.java b24cb35 
>   tools/src/main/java/org/apache/sqoop/tools/tool/JSONConstants.java PRE-CREATION 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java PRE-CREATION

>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/21898/diff/
> 
> 
> Testing
> -------
> 
> Manual testing. Dumping repository with and without sensitive data. Validating resulting
JSON.
> 
> 
> Thanks,
> 
> Gwen Shapira
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message