sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gwen Shapira" <gshap...@cloudera.com>
Subject Re: Review Request 21898: Patch for SQOOP-1255 - https://issues.apache.org/jira/browse/SQOOP-1255
Date Mon, 21 Jul 2014 19:34:44 GMT


> On July 18, 2014, 7:50 p.m., Abraham Elmahrek wrote:
> > tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java, lines 62-69
> > <https://reviews.apache.org/r/21898/diff/6/?file=635435#file635435line62>
> >
> >     Many of these strings seem frequently used. Why not pull them out into constants?
Though, this might not matter with String interning.

Probably doesn't matter either way since each is used twice. I'll add a constants class (to
share between dump and load tools) if this gets out of control.


- Gwen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21898/#review48144
-----------------------------------------------------------


On July 18, 2014, 4:11 p.m., Gwen Shapira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21898/
> -----------------------------------------------------------
> 
> (Updated July 18, 2014, 4:11 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Added tool for dumping user-generated data - connections, jobs and submissions. There's
an option to dump sensitive data (i.e. passwords) as well. 
> 
> 
> Diffs
> -----
> 
>   docs/src/site/sphinx/Tools.rst ad72cd1 
>   pom.xml 1e2f005 
>   tools/pom.xml 31eda1c 
>   tools/src/main/java/org/apache/sqoop/tools/tool/BuiltinTools.java b24cb35 
>   tools/src/main/java/org/apache/sqoop/tools/tool/JSONConstants.java PRE-CREATION 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java PRE-CREATION

>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/21898/diff/
> 
> 
> Testing
> -------
> 
> Manual testing. Dumping repository with and without sensitive data. Validating resulting
JSON.
> 
> 
> Thanks,
> 
> Gwen Shapira
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message