sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gwen Shapira" <gshap...@cloudera.com>
Subject Re: Review Request 21898: Patch for SQOOP-1255 - https://issues.apache.org/jira/browse/SQOOP-1255
Date Mon, 21 Jul 2014 19:39:09 GMT


> On May 26, 2014, 1:50 a.m., Jarek Cecho wrote:
> > tools/src/main/java/org/apache/sqoop/tools/tool/DataDumpTool.java, line 57
> > <https://reviews.apache.org/r/21898/diff/1/?file=594245#file594245line57>
> >
> >     I think that the idea is that user should be able to use the dump to load data
back to repository (e.g. for backup purpose or during migration from one repository to another
one). Something like mysqldump & mysqlimport. Hence two high level notes:
> >     
> >     * I would assume that the extra messages "dumping ..." will cause issues when
parsing the text. 
> >     * We do need to output some information about the connectors though. The connection
will contain connector ID without specifying what exact connector has been there - this might
be a trouble as different connectors might have different IDs on different repositories. We
don't necessary have to print out entire connector info, but at least the associated unique
identification.

Re, first note:
The tools framework itself is writing messages to stdout, and I think they are pretty helpful
(version, etc).
I think it will be cleanest to take an extra parameter with output filename and write the
JSON to a file. 


> On May 26, 2014, 1:50 a.m., Jarek Cecho wrote:
> > tools/src/main/java/org/apache/sqoop/tools/tool/BuiltinTools.java, line 39
> > <https://reviews.apache.org/r/21898/diff/1/?file=594244#file594244line39>
> >
> >     The "datadump" might suggest that Sqoop will do some data transfer. What about
using word "repo" or "repository" instead? Something like "repositorydump", "repodump" or
"repositoryexport", "repoexport"?

RepositoryDump sounds good to me.
The word "dump" is staying. Its a pretty standard ORM term for doing exactly what we are doing
here, and the word "Export" is already used in Sqoop context.


- Gwen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21898/#review43910
-----------------------------------------------------------


On July 18, 2014, 4:11 p.m., Gwen Shapira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21898/
> -----------------------------------------------------------
> 
> (Updated July 18, 2014, 4:11 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Added tool for dumping user-generated data - connections, jobs and submissions. There's
an option to dump sensitive data (i.e. passwords) as well. 
> 
> 
> Diffs
> -----
> 
>   docs/src/site/sphinx/Tools.rst ad72cd1 
>   pom.xml 1e2f005 
>   tools/pom.xml 31eda1c 
>   tools/src/main/java/org/apache/sqoop/tools/tool/BuiltinTools.java b24cb35 
>   tools/src/main/java/org/apache/sqoop/tools/tool/JSONConstants.java PRE-CREATION 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java PRE-CREATION

>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/21898/diff/
> 
> 
> Testing
> -------
> 
> Manual testing. Dumping repository with and without sensitive data. Validating resulting
JSON.
> 
> 
> Thanks,
> 
> Gwen Shapira
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message