sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gwen Shapira" <gshap...@cloudera.com>
Subject Re: Review Request 23943: Sqoop2: From/To: End to End refactoring
Date Fri, 25 Jul 2014 20:11:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23943/#review48764
-----------------------------------------------------------

Ship it!


Ship It!

- Gwen Shapira


On July 25, 2014, 8:03 p.m., Abraham Elmahrek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23943/
> -----------------------------------------------------------
> 
> (Updated July 25, 2014, 8:03 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1376, SQOOP-1377, SQOOP-1380, and SQOOP-1381
>     https://issues.apache.org/jira/browse/SQOOP-1376
>     https://issues.apache.org/jira/browse/SQOOP-1377
>     https://issues.apache.org/jira/browse/SQOOP-1380
>     https://issues.apache.org/jira/browse/SQOOP-1381
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> This review contains modifications to just about every component in order to properly
transfer data FROM one data source TO another.
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/SqoopClient.java 05ea6d6 
>   client/src/main/java/org/apache/sqoop/client/request/ConnectionRequest.java f523abb

>   client/src/main/java/org/apache/sqoop/client/request/JobRequest.java 6dee2c8 
>   client/src/main/java/org/apache/sqoop/client/request/SqoopRequests.java ffaa84f 
>   common/src/main/java/org/apache/sqoop/common/ConnectorType.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/json/ConnectionValidationBean.java PRE-CREATION

>   common/src/main/java/org/apache/sqoop/json/ConnectorBean.java cbe049a 
>   common/src/main/java/org/apache/sqoop/json/FrameworkBean.java eb79f98 
>   common/src/main/java/org/apache/sqoop/json/JobBean.java 1555bd5 
>   common/src/main/java/org/apache/sqoop/json/JobValidationBean.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/json/ValidationBean.java fd36825 
>   common/src/main/java/org/apache/sqoop/model/MConnector.java 43fad27 
>   common/src/main/java/org/apache/sqoop/model/MFramework.java c742459 
>   common/src/main/java/org/apache/sqoop/model/MJob.java 849168d 
>   common/src/main/java/org/apache/sqoop/model/MJobForms.java f697023 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java
e0da80f 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorConstants.java
abcc89d 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportDestroyer.java
c5faa09 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportInitializer.java
ef39cdc 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportLoader.java
15e7101 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExtractor.java
PRE-CREATION 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromDestroyer.java
PRE-CREATION 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromInitializer.java
PRE-CREATION 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportDestroyer.java
2cf07fe 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportExtractor.java
3f9aa9b 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java
96818ba 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartition.java
66ed556 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartitioner.java
d103223 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcLoader.java
PRE-CREATION 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartition.java
PRE-CREATION 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartitioner.java
PRE-CREATION 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcToDestroyer.java
PRE-CREATION 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcToInitializer.java
PRE-CREATION 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java
0c5f6e1 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ExportJobConfiguration.java
f2b2d65 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ExportTableForm.java
14a7033 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfiguration.java
PRE-CREATION 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromTableForm.java
PRE-CREATION 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ImportJobConfiguration.java
f3c1d13 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ImportTableForm.java
0991b28 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfiguration.java
PRE-CREATION 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToTableForm.java
PRE-CREATION 
>   connector/connector-mysql-jdbc/src/main/java/org/apache/sqoop/connector/mysqljdbc/MySqlJdbcConnector.java
17215f0 
>   core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java b80de7f 
>   core/src/main/java/org/apache/sqoop/framework/ExecutionEngine.java f43942d 
>   core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java 505121c 
>   core/src/main/java/org/apache/sqoop/framework/FrameworkValidator.java f5f6a36 
>   core/src/main/java/org/apache/sqoop/framework/JobManager.java e052584 
>   core/src/main/java/org/apache/sqoop/framework/SubmissionRequest.java 53d0039 
>   core/src/main/java/org/apache/sqoop/framework/configuration/JobConfiguration.java PRE-CREATION

>   core/src/main/java/org/apache/sqoop/repository/Repository.java ecf5004 
>   execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java
5c0a027 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/JobConstants.java 7fd9a01 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsExportExtractor.java
1978ec6 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java bd11323

>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java
e1a95a7 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat.java 6891258

>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java 92de37e

>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java
7dedee9 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
5bce3a9 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
fcbb475 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
7042a53 
>   server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java c9c7648

>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 362ba79 
>   shell/src/main/java/org/apache/sqoop/shell/CloneJobFunction.java f80552c 
>   shell/src/main/java/org/apache/sqoop/shell/CreateJobFunction.java 598adbc 
>   shell/src/main/java/org/apache/sqoop/shell/DeleteConnectionFunction.java 54d8e9a 
>   shell/src/main/java/org/apache/sqoop/shell/ShowConnectionFunction.java 6e5c9b5 
>   shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java 9a5386c 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java b060bb4 
>   shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 475f41c 
>   shell/src/main/java/org/apache/sqoop/shell/utils/FormDisplayer.java 56e0b4e 
>   shell/src/main/java/org/apache/sqoop/shell/utils/FormFiller.java c491ae5 
>   shell/src/main/java/org/apache/sqoop/shell/utils/JobDynamicFormOptions.java aa118e1

>   shell/src/main/resources/shell-resource.properties df9457d 
>   spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 2becc56 
>   spi/src/main/java/org/apache/sqoop/job/etl/Exporter.java cdaa623 
>   spi/src/main/java/org/apache/sqoop/job/etl/From.java PRE-CREATION 
>   spi/src/main/java/org/apache/sqoop/job/etl/Importer.java d4c9e70 
>   spi/src/main/java/org/apache/sqoop/job/etl/To.java PRE-CREATION 
>   spi/src/main/java/org/apache/sqoop/validation/Validator.java cf0b4aa 
>   submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java
6fc485b 
> 
> Diff: https://reviews.apache.org/r/23943/diff/
> 
> 
> Testing
> -------
> 
> Can transfer data from MySQL to PostgreSQL successfully (hangs because of Class.forName
call, which we will debug after this is in).
> 
> 
> Thanks,
> 
> Abraham Elmahrek
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message