sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abraham Elmahrek" <...@cloudera.com>
Subject Re: Review Request 23944: Sqoop2: From/To: Refactor models
Date Thu, 31 Jul 2014 18:12:39 GMT


> On July 25, 2014, 8:10 p.m., Gwen Shapira wrote:
> > Shouldn't it be ConnectorFormType? Since we have two types of Forms but only one
type of connector?

Actually, ConnectorType seems to work since it's more about how he connector is configured
and less about the forms. We could use ConnectorDirection, ConnectorCategory, ConnectorPosition,
etc.


- Abraham


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23944/#review48763
-----------------------------------------------------------


On July 25, 2014, 8:08 p.m., Abraham Elmahrek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23944/
> -----------------------------------------------------------
> 
> (Updated July 25, 2014, 8:08 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1376
>     https://issues.apache.org/jira/browse/SQOOP-1376
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> - Removed Job.Type and created ConnectorType.FROM/TO (not included in Review).
> - MConnector is the only model which has two sets of forms.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/sqoop/model/MConnector.java 43fad27 
>   common/src/main/java/org/apache/sqoop/model/MFramework.java c742459 
>   common/src/main/java/org/apache/sqoop/model/MJob.java 849168d 
>   common/src/main/java/org/apache/sqoop/model/MJobForms.java f697023 
> 
> Diff: https://reviews.apache.org/r/23944/diff/
> 
> 
> Testing
> -------
> 
> N/A
> 
> 
> Thanks,
> 
> Abraham Elmahrek
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message