sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abraham Elmahrek" <...@cloudera.com>
Subject Re: Review Request 24242: SQOOP-1405: Extra arg to enable SQL Server identity insert on export
Date Tue, 05 Aug 2014 23:27:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24242/#review49657
-----------------------------------------------------------


Thanks for working on this! Just a couple of comments below.


src/java/org/apache/sqoop/mapreduce/SQLServerExportDBExecThread.java
<https://reviews.apache.org/r/24242/#comment86906>

    Should this have a semicolon at the end of it?
    
    Also, does it make any sense to separate this out into its own statement?



src/java/org/apache/sqoop/mapreduce/sqlserver/SqlServerExportBatchOutputFormat.java
<https://reviews.apache.org/r/24242/#comment86907>

    Should this have a semicolon at the end of it?
    
    Also, does it make any sense to separate this out into its own statement?


- Abraham Elmahrek


On Aug. 4, 2014, 5:48 p.m., Keegan Witt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24242/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2014, 5:48 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Adds an extra arg for SQL Server that runs SET IDENTITY_INSERT <table> ON before
exporting the data.
> 
> 
> Diffs
> -----
> 
>   src/docs/user/connectors.txt bba946a 
>   src/java/org/apache/sqoop/manager/SQLServerManager.java 534c0cc 
>   src/java/org/apache/sqoop/mapreduce/SQLServerExportDBExecThread.java 1810ba8 
>   src/java/org/apache/sqoop/mapreduce/sqlserver/SqlServerExportBatchOutputFormat.java
cc69d77 
> 
> Diff: https://reviews.apache.org/r/24242/diff/
> 
> 
> Testing
> -------
> 
> Tested that change enables inserts on tables with identity (with SQL Server 2005).
> 
> 
> Thanks,
> 
> Keegan Witt
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message