sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request 23946: Sqoop2: From/To: JobManager modifications
Date Thu, 07 Aug 2014 01:18:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23946/#review49850
-----------------------------------------------------------

Ship it!



core/src/main/java/org/apache/sqoop/framework/JobManager.java
<https://reviews.apache.org/r/23946/#comment87241>

    I would expect that similar check will be there for both from and to? I think that we
can do it in follow up JIRA.



core/src/main/java/org/apache/sqoop/framework/JobManager.java
<https://reviews.apache.org/r/23946/#comment87242>

    I believe that one framework is fine, we don't need two instances of the same forms as
they should contain pretty much the same values.


- Jarek Cecho


On July 25, 2014, 8:18 p.m., Abraham Elmahrek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23946/
> -----------------------------------------------------------
> 
> (Updated July 25, 2014, 8:18 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1376
>     https://issues.apache.org/jira/browse/SQOOP-1376
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Job manager actually sets:
> - connection connector from forms
> - connection connector to forms
> - connection framework from forms
> - connection framework to forms
> - job connector from forms
> - job connector to forms
> - job framework forms
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/sqoop/framework/JobManager.java e052584 
> 
> Diff: https://reviews.apache.org/r/23946/diff/
> 
> 
> Testing
> -------
> 
> N/A
> 
> 
> Thanks,
> 
> Abraham Elmahrek
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message