sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request 24179: SQOOP-1411: The number of tasks is not set properly in PGBulkloadExportManager
Date Sat, 09 Aug 2014 17:48:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24179/#review50115
-----------------------------------------------------------



src/java/org/apache/sqoop/mapreduce/JobBase.java
<https://reviews.apache.org/r/24179/#comment87679>

    This class is part of connector public interface, so I'm afraid that changing name of
this method is backward incompatible change.
    
    I would suggest adding the original method with comment that is sets only number of map
tasks and that it's preserved from backward compatibility reasons.


- Jarek Cecho


On Aug. 5, 2014, 12:07 a.m., Masatake Iwasaki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24179/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2014, 12:07 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1411
>     https://issues.apache.org/jira/browse/SQOOP-1411
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> This patch fixes configureNumTasks. It changes the property for specifying the number
of reduce task from "mapred.reduce.tasks" to "pgbulkload.job.reduces".
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/mapreduce/ExportJobBase.java 9f510b9 
>   src/java/org/apache/sqoop/mapreduce/ImportJobBase.java 0ac35de 
>   src/java/org/apache/sqoop/mapreduce/JobBase.java 92a78ac 
>   src/java/org/apache/sqoop/mapreduce/postgresql/PGBulkloadExportJob.java 1e2ad9f 
>   src/test/com/cloudera/sqoop/manager/PGBulkloadManagerManualTest.java 4d03a8b 
> 
> Diff: https://reviews.apache.org/r/24179/diff/
> 
> 
> Testing
> -------
> 
> * passed ant test
> * passed PGBulkloadManagerManualTest against postgresql-9.2.9 and pg_bulkload-3.1.6.
> 
> 
> Thanks,
> 
> Masatake Iwasaki
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message