sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abraham Elmahrek (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (SQOOP-1343) Sqoop2: Provide validation utilities
Date Fri, 15 Aug 2014 18:19:18 GMT

     [ https://issues.apache.org/jira/browse/SQOOP-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Abraham Elmahrek resolved SQOOP-1343.
-------------------------------------

    Resolution: Won't Fix

In favor of validation refactoring seen in SQOOP-1439 and SQOOP-1440.

> Sqoop2: Provide validation utilities
> ------------------------------------
>
>                 Key: SQOOP-1343
>                 URL: https://issues.apache.org/jira/browse/SQOOP-1343
>             Project: Sqoop
>          Issue Type: Sub-task
>            Reporter: Abraham Elmahrek
>
> Instead of:
> {code}
>     if(input.inputDirectory == null || input.inputDirectory.isEmpty()) {
>       validation.addMessage(Status.UNACCEPTABLE, "input", "inputDirectory", "Input directory
is empty");
>     }
> {code}
> It would be nice to reuse logic:
> {code}
> validation.checkNotNullOrBlank(input.inputDirectory, Status.UNACCEPTABLE, "input", "inputDirectory",
"Input directory is empty");
> {code}
> Or something similar.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message