sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Jarcec Cecho (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-1384) Sqoop2: From/To: Refactor Generic JDBC Connector
Date Wed, 13 Aug 2014 02:59:12 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14095080#comment-14095080
] 

Jarek Jarcec Cecho commented on SQOOP-1384:
-------------------------------------------

* {{ConfigurationUtils.java:264}}
{code}
  /**
   * Retrieve From Connector generated schema.
   *
   * @param job MapReduce Job object
   * @param schema Schema
   */
  public static Schema getConnectorSchema(ConnectorType type, Configuration configuration)
{
{code}
It seems that the patch is changing the {{@Param}} properties to incorrect ones?

* {{FromJobConfiguration.java}}
{code}
public class FromJobConfiguration {
  @Form public FromTableForm fromTable;

  public FromJobConfiguration() {
    fromTable = new FromTableForm();
  }
}
{code}
I'm wondering if the rename is really required here? The variable {{table}} is already in
{{FromJobConfiguration}}, so is there any benefit of the rename?

* {{JobRequestHandler.java:31}}
{code}
import org.apache.sqoop.model.MConnector;
{code}
We're adding import that is not used?

* {{ToJobConfiguration.java}}
{code}
public class ToJobConfiguration {
  @Form public ToTableForm toTable;

  public ToJobConfiguration() {
    toTable = new ToTableForm();
  }
}
{code}
Similarly, is that rename really necessary here?

> Sqoop2: From/To: Refactor Generic JDBC Connector
> ------------------------------------------------
>
>                 Key: SQOOP-1384
>                 URL: https://issues.apache.org/jira/browse/SQOOP-1384
>             Project: Sqoop
>          Issue Type: Sub-task
>            Reporter: Abraham Elmahrek
>            Assignee: Abraham Elmahrek
>             Fix For: from/to
>
>         Attachments: SQOOP-1384.0.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message