sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Review Request 25220: SQOOP-1465 Sqoop2: Validations: Add support for multiple validation messages to Model classes
Date Mon, 01 Sep 2014 08:06:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25220/
-----------------------------------------------------------

Review request for Sqoop.


Repository: sqoop-SQOOP-1367


Description
-------

I've rewritten the MValidatedElement class and it's associated test and fixed every usage
of this class to be compatible with multiple validation mesages.


Diffs
-----

  common/src/main/java/org/apache/sqoop/model/FormUtils.java 927d4e6 
  common/src/main/java/org/apache/sqoop/model/MValidatedElement.java ab5473c 
  common/src/main/java/org/apache/sqoop/validation/Status.java ae89e59 
  common/src/test/java/org/apache/sqoop/model/TestFormUtils.java 08dfa7b 
  common/src/test/java/org/apache/sqoop/model/TestMValidatedElement.java 3fd5a95 
  shell/src/main/java/org/apache/sqoop/shell/utils/FormDisplayer.java e04d7b5 
  shell/src/main/java/org/apache/sqoop/shell/utils/FormFiller.java 9d63c6e 

Diff: https://reviews.apache.org/r/25220/diff/


Testing
-------

Existing and new unit tests are passing.


Thanks,

Jarek Cecho


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message