sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Keegan Witt" <keeganw...@gmail.com>
Subject Re: Review Request 26280: SQOOP-1403
Date Thu, 02 Oct 2014 20:58:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26280/
-----------------------------------------------------------

(Updated Oct. 2, 2014, 4:58 p.m.)


Review request for Sqoop.


Repository: sqoop-trunk


Description
-------

SQOOP-1403_3.patch review


Diffs
-----

  COMPILING.txt 138dc0a 
  src/java/org/apache/sqoop/manager/SQLServerManager.java fdd4e91 
  src/java/org/apache/sqoop/mapreduce/sqlserver/SqlServerUpsertOutputFormat.java PRE-CREATION

  src/test/com/cloudera/sqoop/manager/SQLServerManagerExportManualTest.java 1d4534b 
  src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java 27860c2 
  src/test/org/apache/sqoop/mapreduce/sqlserver/SqlServerUpsertOutputFormatTest.java PRE-CREATION


Diff: https://reviews.apache.org/r/26280/diff/


Testing
-------

* Tested against our (eBay Enterprise's) SQL Server instances by including these changes in
a jar that I forced to be first on the classpath.
* Successfully ran new unit and integration tests.


Thanks,

Keegan Witt


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message