sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abraham Elmahrek" <...@cloudera.com>
Subject Re: Review Request 26295: SQOOP-1477: Sqoop2: Make link and job name unique identifier
Date Fri, 03 Oct 2014 04:06:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26295/
-----------------------------------------------------------

(Updated Oct. 3, 2014, 4:06 a.m.)


Review request for Sqoop.


Changes
-------

New review with Gwen's and Veena's feedback.

NOTE: Upgrades will fail if there are non-null names that are the same for 2 different jobs
or 2 different links.


Bugs: SQOOP-1477
    https://issues.apache.org/jira/browse/SQOOP-1477


Repository: sqoop-SQOOP-1367


Description
-------

commit 450db6146922bc197bb7c3eda375319788d610ba
Author: Abraham Elmahrek <abraham@elmahrek.com>
Date:   Thu Oct 2 16:19:21 2014 -0700

    SQOOP-1477: Sqoop2: Make link and job name unique identifier

:100644 100644 3466116... e7d4589... M  core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java
:100644 100644 a743491... 792306e... M  core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java
:100644 100644 54e37d9... 2489c58... M  core/src/main/java/org/apache/sqoop/repository/RepositoryError.java
:100644 100644 19b0023... e9a6075... M  core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java
:100644 100644 5dd7970... 1ea388f... M  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
:100644 100644 ad42901... d38d789... M  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java


Diffs (updated)
-----

  core/src/main/java/org/apache/sqoop/repository/RepositoryError.java 54e37d9 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
5dd7970 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
58eed2d 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
ad42901 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
4b95687 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java
47350ea 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java
8dd1ce2 

Diff: https://reviews.apache.org/r/26295/diff/


Testing
-------

mvn clean test


Thanks,

Abraham Elmahrek


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message