sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abraham Elmahrek" <...@cloudera.com>
Subject Re: Review Request 25090: SQOOP-1471: Use Hadoop CredentialProvider API to encyrpt passwords at rest
Date Tue, 07 Oct 2014 19:30:35 GMT


> On Oct. 7, 2014, 7:10 p.m., Abraham Elmahrek wrote:
> > Ship It!

Venkat, it seems there are test failures: org.apache.sqoop.credentials.TestPassingSecurePassword.
Could you fix them?


- Abraham


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25090/#review55684
-----------------------------------------------------------


On Sept. 25, 2014, 11:43 p.m., Venkat Ranganathan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25090/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2014, 11:43 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1471
>     https://issues.apache.org/jira/browse/SQOOP-1471
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Use the Hadoop Credential Provider facility to use password aliases instead of password
so that password need not be embedded in clear text in scipts and password files.
> 
> Enhanced both the password on the command line with a password-alias opton and also the
ability to store an alias instead of clear text in the password file option.
> 
> Used reflection to call the APIs instead of directly accessing them so that we don't
have hard dependency on Hadoop 2.6.x
> 
> Added documentation updates
> 
> Made sure no new checkstyle violations are there
> 
> 
> Diffs
> -----
> 
>   src/docs/user/connecting.txt 6a28254 
>   src/java/org/apache/sqoop/SqoopOptions.java d16ccb3 
>   src/java/org/apache/sqoop/tool/BaseSqoopTool.java 498ad79 
>   src/java/org/apache/sqoop/util/password/CredentialProviderHelper.java PRE-CREATION

>   src/java/org/apache/sqoop/util/password/CredentialProviderPasswordLoader.java PRE-CREATION

>   src/java/org/apache/sqoop/util/password/FilePasswordLoader.java 4a288bf 
>   src/test/org/apache/sqoop/credentials/TestPassingSecurePassword.java bbf82f4 
> 
> Diff: https://reviews.apache.org/r/25090/diff/
> 
> 
> Testing
> -------
> 
> Tested with Hadoop versions 2.4 and 1.x to make sure we fail gracefully if the facility
is not available.   Tested with 2.6.0 snapshot build that was built by myself and also against
the SNAPSHOT builds posted to validate the functionality.
> 
> Added two new tests to test the functionality
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message